6.0.0-beta1
7/8/25

[#10326] even more Ulaform refactoring for H4
Summary even more Ulaform refactoring for H4
Queue Ulaform
Type Enhancement
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester vilius (at) lnk (dot) lt
Created 07/09/2011 (5113 days ago)
Due
Updated 07/12/2011 (5110 days ago)
Assigned
Resolved 07/12/2011 (5110 days ago)
Milestone
Patch Yes

History
07/12/2011 11:45:24 AM Jan Schneider Comment #6 Reply to this comment
- You can simplify redirection by using Horde::url('foo.php')->redirect()
Does adding redirect() automatically assumes that URL is full and I 
don't need second parameter? Or do I still need 
Horde::url('foo.php', true)->redirect() ?
Strictly you still need the 2nd parameter. I don't know any browser 
that doesn't support relative path redirections, but it's not official 
HTTP standard.
07/12/2011 11:05:12 AM vilius (at) lnk (dot) lt Comment #5 Reply to this comment
- I've seen a few cases where you handle legacy lowercase action 
names. How about adding a migration instead to ucfirst the actions 
in the forms table once and for all?
When I  started refactoring I thought that legacy action handling must 
be done only in one or two places and that it will be easier. But now 
I'm convinced that migration script probably would have been a better 
idea. Will prepare a patch later.
- You can simplify redirection by using Horde::url('foo.php')->redirect()
Does adding redirect() automatically assumes that URL is full and I 
don't need second parameter? Or do I still need Horde::url('foo.php', 
true)->redirect() ?
07/12/2011 10:49:41 AM Jan Schneider Comment #4
Assigned to Jan Schneider
State ⇒ Resolved
Reply to this comment
- I've seen a few cases where you handle legacy lowercase action 
names. How about adding a migration instead to ucfirst the actions in 
the forms table once and for all?
- You can simplify redirection by using Horde::url('foo.php')->redirect()
07/12/2011 10:49:29 AM Git Commit Comment #3 Reply to this comment
Changes have been made in Git for this ticket:

No need to re-throw (Request #10326).

  1 files changed, 1 insertions(+), 5 deletions(-)
http://git.horde.org/horde-git/-/commit/4212a9bb30c6031df21b9ff4d855713648ebbe18
07/12/2011 10:49:23 AM Git Commit Comment #2 Reply to this comment
Changes have been made in Git for this ticket:

private -> protected (Request #10326).

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/9765febfa01bbb960639ea80032e75009de2b9e2
07/09/2011 06:25:18 PM vilius (at) lnk (dot) lt Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ even more Ulaform refactoring for H4
Queue ⇒ Ulaform
Milestone ⇒
Patch ⇒ Yes
New Attachment: ulaformregactoring.tar.gz Download
State ⇒ New
Reply to this comment
Main changes:

* Fixed Mailto action driver to use Horde_Mime_Mail().
* PEAR_Error -> Exceptions.
* Horde_Util::addParameter -> Horde::url.
* Autoloading.
* OOP fixes.

I still have Horde_Template -> Horde_View patch to work on, but 
hopefully after that Ulaform can be released as beta.

Saved Queries