Summary | No HTTP_Auth when accessing users *.ics file |
Queue | Kronolith |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | mail (at) xeroc (dot) org |
Created | 06/24/2011 (5135 days ago) |
Due | |
Updated | 08/29/2012 (4703 days ago) |
Assigned | 06/24/2011 (5135 days ago) |
Resolved | 10/15/2011 (5022 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
commit 067e1deb555ff3d3d24739ae8a2d8c8a8b585666
Author: Jan Schneider <jan@horde.org>
Date: Sat Oct 15 13:11:09 2011 +0200
[jan] Catch exceptions from imap library (
Bug #10272).framework/Auth/lib/Horde/Auth/Imap.php | 8 ++++++--
framework/Auth/package.xml | 4 ++--
2 files changed, 8 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/067e1deb555ff3d3d24739ae8a2d8c8a8b585666
State ⇒ Resolved
[jan] Catch exceptions from imap library (
Bug #10272).2 files changed, 8 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/b03c00ed39d3b3fb1696309af88f88d4909574c0
before sending the HTTP_Auth header. I would suggest checking for
empty(null passwords) in _check_auth() before handling it with
checkAuth or check_auth().
without the credentials, which we reply with an authentication
request. Next time the client request will include the credentials, so
we need to check them before sending an authentication request again.
Otherwise the client would never be able to authenticate successfully.
even in a Git master checkout from June.
line 952
I don't understand, why you check for a valid authentication even
before sending the HTTP_Auth header. I would suggest checking for
empty(null passwords) in _check_auth() before handling it with
checkAuth or check_auth().
But I am not a horde developer and so dont see the full picture. I
patched it the following way.
Thanks for further statements.
======================================
diff --git a/framework/Rpc/lib/Horde/Rpc/Webdav.php
b/framework/Rpc/lib/Horde/Rpc/Webdav.php
index 9071c3e..aea3347 100644
--- a/framework/Rpc/lib/Horde/Rpc/Webdav.php
+++ b/framework/Rpc/lib/Horde/Rpc/Webdav.php
@@ -2420,6 +2420,11 @@ class Horde_Rpc_Webdav extends Horde_Rpc
? $this->_SERVER["PHP_AUTH_PW"]
: null;
+ if (is_null($auth_user) ||
+ is_null($auth_pw)) {
+ return false;
+ }
+
if (method_exists($this, "checkAuth")) {
// PEAR style method name
return $this->checkAuth($auth_type, $auth_user, $auth_pw);
======================================
State ⇒ Feedback
b/framework/Rpc/lib/Horde/Rpc/Webdav.php
index 9071c3e..11a2365 100644
--- a/framework/Rpc/lib/Horde/Rpc/Webdav.php
+++ b/framework/Rpc/lib/Horde/Rpc/Webdav.php
@@ -2420,6 +2420,10 @@ class Horde_Rpc_Webdav extends Horde_Rpc
? $this->_SERVER["PHP_AUTH_PW"]
: null;
+ if ($auth_user == null || $auth_pw == null) {
+ return false;
+ }
+
if (method_exists($this, "checkAuth")) {
// PEAR style method name
return $this->checkAuth($auth_type, $auth_user, $auth_pw);
#9893.1.0.5) and the bug is not resolved (as in the other ticket).
But I am using a '@' in the usename.
State ⇒ Duplicate
#9893.Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ No HTTP_Auth when accessing users *.ics file
Due ⇒ 06/24/2011
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
I currently use git-master (d3f28851eb029113c37caf3d9da50652358c88ed)
and can remember when using the latest-stable, that there was a
HTTP_Auth request, whenever I wanted to download my own calendar ics
file:
Link is
<https://horde.xeroc.org/rpc.php/kronolith/mail@xeroc.org/3I91aTMRB6ROAzCCtw_ATIA.ics>
But when updating to git-master I noticed, that there is no HTTP_Auth
anymore, Instead theres the error msg:
"Horde_Imap_Client requires a username and password."
See URL for traceback.
Did I miss a checkbox I needed for this to work?
Thanks for the great piece of software anyway.