6.0.0-beta1
7/21/25

[#10219] IMP summary block improvements
Summary IMP summary block improvements
Queue IMP
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester vilius (at) lnk (dot) lt
Created 06/09/2011 (5156 days ago)
Due
Updated 06/10/2011 (5155 days ago)
Assigned
Resolved 06/09/2011 (5156 days ago)
Milestone
Patch Yes

History
06/10/2011 05:30:33 PM Michael Slusarz Comment #7 Reply to this comment
* Unseen count should not be linked.
Why? It was very useful.
it is inconsistent UI.  Why is *only* the unseen column linked?  Why 
not New messages?  Or Total messages?

Either the entire row is linked, or one element is linked.  If 
multiple elements (but not all) are linked, the understanding is that 
those links do different things.  That was not the case.
* Remove separate column for New.
I don't agree that this change is better, because in some languages 
"new" becomes twice that long or even longer. But anyway, it should 
use ngettext() to take plulars into account.
The presence of recent messages is the exception, not the norm.   
Having an entirely empty row the vast majority of the time just pushes 
the total message count further away from the subject of the row (the 
mailbox name), making it harder to read.

The ngettext() call is a valid point - it was originally in there when 
I first fixed up the block but got lost somewhere in the last month.   
It has been re-added.
06/10/2011 05:25:53 PM Git Commit Comment #6 Reply to this comment
Changes have been made in Git for this ticket:

Request #10219: Readd ngettext() call for 'new' string

  1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/78b0b3c7f984d265c7779aa0e0075d0402b27c3e
06/10/2011 05:12:51 AM vilius (at) lnk (dot) lt Comment #5 Reply to this comment
* Unseen count should not be linked.
Why? It was very useful.
* Remove separate column for New.
I don't agree that this change is better, because in some languages 
"new" becomes twice that long or even longer. But anyway, it should 
use ngettext() to take plulars into account.
06/09/2011 07:33:15 PM Michael Slusarz Comment #4
Assigned to Michael Slusarz
State ⇒ Resolved
Reply to this comment
Tweaked and committed.

Changes:
* Unseen count should not be linked.
* Remove separate column for New.
* Empty mailboxes should have message count of 0.
* Add placeholder for mailboxes with no unseen messages.
06/09/2011 07:30:35 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git for this ticket:

Request #10219: Improve mail summary block.
Signed-off-by: Michael M Slusarz <slusarz@curecanti.org>

  2 files changed, 25 insertions(+), 38 deletions(-)
http://git.horde.org/horde-git/-/commit/73e21acac4674dc576cb78990fe6a24481326bbe
06/09/2011 12:59:24 PM vilius (at) lnk (dot) lt Comment #2
New Attachment: 0002-Tweak-new-message-count-display.patch Download
Reply to this comment
Another "nice touch" for the block. I'm sending this in a separate 
part of the patch, because not everyone can like it though.
06/09/2011 12:51:45 PM vilius (at) lnk (dot) lt Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ IMP summary block improvements
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ Yes
New Attachment: 0001-Improve-mail-summary-block.patch Download
State ⇒ New
Reply to this comment
Following the discussion on the list here are some improvements for 
IMP summary block. I have also removed Total Message Count parameter 
from that block configuration. It doesn't have a point anymore as we 
have a full table with self-explanatory columns now, instead of 
previous "(x) (x new) x".

Saved Queries