| Summary | Move a rule always move by one step |
| Queue | Ingo |
| Queue Version | 2.0.1 |
| Type | Bug |
| State | Resolved |
| Priority | 2. Medium |
| Owners | jan (at) horde (dot) org |
| Requester | olivier (at) ablinux (dot) com |
| Created | 06/01/2011 (5147 days ago) |
| Due | |
| Updated | 06/02/2011 (5146 days ago) |
| Assigned | |
| Resolved | 06/02/2011 (5146 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | 2.0.2 |
| Patch | No |
State ⇒ Resolved
Milestone ⇒ 2.0.2
[jan] Fix moving rules to an explicit position (
Bug #10172).3 files changed, 5 insertions(+), 4 deletions(-)
http://git.horde.org/horde-git/-/commit/e5c69f499a5f1efd220ee81137e82bb64e23bbe6
Priority ⇒ 2. Medium
Patch ⇒ No
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ Move a rule always move by one step
Type ⇒ Bug
State ⇒ Unconfirmed
rightest input form field corresponding to the rule and indicating the
new number, the rule is always move by one, not by the specified number.
It seems to be a bug in ingo/filters.php, for case rule_up and rule_down...
case 'rule_up':
$filters->ruleUp($vars->rulenumber, $vars->steps || 1);
break;
case 'rule_down':
$filters->ruleDown($vars->rulenumber, $vars->steps || 1);
break;
The expression "$vars->steps || 1" always returns a true boolean
value, not the form indicated step !!