6.0.0-beta1
7/4/25

[#10147] mailbot quotes the contents of the original message
Summary mailbot quotes the contents of the original message
Queue Ingo
Queue Version Git master
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester rsalmon (at) mbpgroup (dot) com
Created 05/27/2011 (5152 days ago)
Due
Updated 06/30/2011 (5118 days ago)
Assigned 06/02/2011 (5146 days ago)
Resolved 06/30/2011 (5118 days ago)
Milestone
Patch No

History
06/30/2011 09:48:43 AM Jan Schneider Type ⇒ Enhancement
State ⇒ Resolved
Priority ⇒ 1. Low
 
06/30/2011 09:48:31 AM Jan Schneider State ⇒ Resolved
 
06/30/2011 09:48:23 AM Git Commit Comment #6 Reply to this comment
Changes have been made in Git for this ticket:

[jan] Add -N parameter to mailbot calls by default (Request #10147).

  4 files changed, 9 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/8551ffaa1eec7c6a92a12d8f17c51900b09d650d
06/29/2011 06:38:56 PM rsalmon (at) mbpgroup (dot) com Comment #5 Reply to this comment
See also http://markmail.org/thread/6pf73ylv4hsufdjr
According to http://www.courier-mta.org/changelog.html, the -N flag 
has been added with 0.65.1, I don't see anything in the changelog 
when the quoting has been enabled, but according to the mailing list 
thread between 0.63 and 0.65.
and for those who are only using maildrop, not the whole courier 
mail/groupware, this has been changed in version maildrop-2.5.1

http://www.courier-mta.org/maildrop/changelog.html :
2010-08-15  Sam Varshavchik  <mrsam@courier-mta.com>
        * rfc2045/rfc2045reply.c: added donotquote option, to suppress 
autoreply text.
        * maildrop/mailbot.c (main): Add the -N option to mailbot, to set the 
donotquote option.
        * maildir/maildirfilter.c: "noquote" autoreply option adds the -N 
option to the mailbot command line.

06/29/2011 04:43:09 PM Jan Schneider Comment #4 Reply to this comment
See also http://markmail.org/thread/6pf73ylv4hsufdjr
According to http://www.courier-mta.org/changelog.html, the -N flag 
has been added with 0.65.1, I don't see anything in the changelog when 
the quoting has been enabled, but according to the mailing list thread 
between 0.63 and 0.65.
06/03/2011 10:17:56 AM rsalmon (at) mbpgroup (dot) com Comment #3 Reply to this comment
This sounds like a BC breaking change in mailbot.
It looks like it.
How are we supposed to know which version is running on that system?
You can't. I seen two options here :
- apply the previous patch in git and add a maildrop version 
requirement in docs (and test.php ?)
- add a command line option in backend.[local].php. in case of 
maildrop, something like
$backends['maildrop']['scriptparams']['args'] = " -N "

and patch will then looks like this:

--- ingo/lib/Script/Maildrop/Recipe.php.org        2011-05-27
14:02:35.000000000 +0200
+++ ingo/lib/Script/Maildrop/Recipe.php        2011-05-27 
14:02:41.000000000 +0200
@@ -153,1 +153,1 @@
-   '| mailbot -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d 
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',
+  '| mailbot ' . $backends['maildrop']['scriptparams']['args'] . ' -D 
%d -c \'UTF-8\' -t $HOME/vacation.msg -d $HOME/vacation -A %s -s %s 
/usr/sbin/sendmail -t',

The second option is much more flexible and can apply to other drivers 
like procmail.
It will be up to the admin to tune is backend.local.php.

06/02/2011 09:45:47 PM Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
This sounds like a BC breaking change in mailbot. How are we supposed 
to know which version is running on that system?
05/27/2011 12:06:34 PM rsalmon (at) mbpgroup (dot) com Comment #1
Milestone ⇒
State ⇒ Unconfirmed
Patch ⇒ Yes
Queue ⇒ Ingo
Summary ⇒ mailbot quotes the contents of the original message
Type ⇒ Bug
Priority ⇒ 1. Low
Reply to this comment
It's rather old (August 2010), but after updating the maildrop package 
today, I noticed that mailbot's default behaviour has changed.

Fom the man page : "
-N
Do not quote the contents of the original message in the message 
create by ?reply?, ?replyall?, and ?replydsn? options. The original 
message gets quoted, in the absence of this option, only if the 
original message was formatted as plain text. mailbot is unable to 
quote an original message which was formatted as HTML, or any other 
non-plaintext format.
"

So here is a patch to mimic the old behaviour (what an end user would 
expect) of the vacation rule,

--- ingo/lib/Script/Maildrop/Recipe.php.org        2011-05-27 
14:02:35.000000000 +0200
+++ ingo/lib/Script/Maildrop/Recipe.php        2011-05-27 14:02:41.000000000 +0200
@@ -153,1 +153,1 @@
-   '| mailbot -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d 
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',
+  '| mailbot -N -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d 
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',

Saved Queries