Summary | mailbot quotes the contents of the original message |
Queue | Ingo |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | rsalmon (at) mbpgroup (dot) com |
Created | 05/27/2011 (5152 days ago) |
Due | |
Updated | 06/30/2011 (5118 days ago) |
Assigned | 06/02/2011 (5146 days ago) |
Resolved | 06/30/2011 (5118 days ago) |
Milestone | |
Patch | No |
State ⇒ Resolved
Priority ⇒ 1. Low
[jan] Add -N parameter to mailbot calls by default (
Request #10147).4 files changed, 9 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/8551ffaa1eec7c6a92a12d8f17c51900b09d650d
According to http://www.courier-mta.org/changelog.html, the -N flag
has been added with 0.65.1, I don't see anything in the changelog
when the quoting has been enabled, but according to the mailing list
thread between 0.63 and 0.65.
mail/groupware, this has been changed in version maildrop-2.5.1
http://www.courier-mta.org/maildrop/changelog.html :
2010-08-15 Sam Varshavchik <mrsam@courier-mta.com>
* rfc2045/rfc2045reply.c: added donotquote option, to suppress
autoreply text.
* maildrop/mailbot.c (main): Add the -N option to mailbot, to set the
donotquote option.
* maildir/maildirfilter.c: "noquote" autoreply option adds the -N
option to the mailbot command line.
According to http://www.courier-mta.org/changelog.html, the -N flag
has been added with 0.65.1, I don't see anything in the changelog when
the quoting has been enabled, but according to the mailing list thread
between 0.63 and 0.65.
- apply the previous patch in git and add a maildrop version
requirement in docs (and test.php ?)
- add a command line option in backend.[local].php. in case of
maildrop, something like
$backends['maildrop']['scriptparams']['args'] = " -N "
and patch will then looks like this:
--- ingo/lib/Script/Maildrop/Recipe.php.org 2011-05-27
14:02:35.000000000 +0200
+++ ingo/lib/Script/Maildrop/Recipe.php 2011-05-27
14:02:41.000000000 +0200
@@ -153,1 +153,1 @@
- '| mailbot -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',
+ '| mailbot ' . $backends['maildrop']['scriptparams']['args'] . ' -D
%d -c \'UTF-8\' -t $HOME/vacation.msg -d $HOME/vacation -A %s -s %s
/usr/sbin/sendmail -t',
The second option is much more flexible and can apply to other drivers
like procmail.
It will be up to the admin to tune is backend.local.php.
State ⇒ Feedback
to know which version is running on that system?
Milestone ⇒
State ⇒ Unconfirmed
Patch ⇒ Yes
Queue ⇒ Ingo
Summary ⇒ mailbot quotes the contents of the original message
Type ⇒ Bug
Priority ⇒ 1. Low
today, I noticed that mailbot's default behaviour has changed.
Fom the man page : "
-N
Do not quote the contents of the original message in the message
create by ?reply?, ?replyall?, and ?replydsn? options. The original
message gets quoted, in the absence of this option, only if the
original message was formatted as plain text. mailbot is unable to
quote an original message which was formatted as HTML, or any other
non-plaintext format.
"
So here is a patch to mimic the old behaviour (what an end user would
expect) of the vacation rule,
--- ingo/lib/Script/Maildrop/Recipe.php.org 2011-05-27
14:02:35.000000000 +0200
+++ ingo/lib/Script/Maildrop/Recipe.php 2011-05-27 14:02:41.000000000 +0200
@@ -153,1 +153,1 @@
- '| mailbot -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',
+ '| mailbot -N -D %d -c \'UTF-8\' -t $HOME/vacation.msg -d
$HOME/vacation -A %s -s %s /usr/sbin/sendmail -t',