Summary | Use memcache flags to keep track of large objects |
Queue | Horde Framework Packages |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | goncalo.queiros (at) portugalmail (dot) net |
Created | 05/25/2011 (5157 days ago) |
Due | |
Updated | 06/04/2011 (5147 days ago) |
Assigned | |
Resolved | 05/26/2011 (5156 days ago) |
Milestone | |
Patch | No |
Bug #10123: Memcache flag fixes.pecl/Memcache version 3.0.3 upwards started to reserve the first 16 bits
Signed-off-by: Michael M Slusarz <slusarz@curecanti.org>
2 files changed, 13 insertions(+), 7 deletions(-)
http://git.horde.org/horde-git/-/commit/cc662ba8c894b0f967c156b4f3e74156d6656142
recent pecl/Memcache as expected.
New Attachment: 0001-pecl-Memcache-version-3.0.3-upwards-started-to-reser.patch
on version 3.0.3
http://pecl.php.net/package-info.php?package=memcache&version=3.0.3)
Also, according to the Memcache protocol
(https://github.com/memcached/memcached/blob/master/doc/protocol.txt#L155) we
can use up to 32 bits since version 1.2.1 (Nov 2006)
every key will cause a cache miss. This returns the platform into a
cold cache state which isn't an expected behavior from a minor
upgrade. We now have upwards 10G of cache data so I think you can
understand how regenerating this data can make a performance hit.
convert old large objects to the new flag system. Attached the temp
patch
implies, is a cache. If data objects suddenly go missing, this is
an expected occurrence.
implies logging everyone out. I agree that memcache isn't the right
solution to store sessions but for our case it seems the best and it's
an horde conf.
As Gonçalo said the warning would make sysadmins aware of these
implications and the patch only makes the transition smoother.
Bug #10123: More correct fix for ignoring old valuesNeed to completely remove the item from the results list, since it is in
the old format and won't be pieced together correctly.
1 files changed, 14 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/861499b90afc4686bd1b471bbaf18f74d2cd4532
State ⇒ Resolved
make the necessary changes. Could you test and make sure I
transferred the changes correctly?
I think that it should be sent to dev (or the appropriate place), a
message to warn people that starting to use this code will bring
unexpected results if they have large objects on memcache.
cache miss.
convert old large objects to the new flag system. Attached the temp
patch
implies, is a cache. If data objects suddenly go missing, this is an
expected occurrence.
Request #10123: part_count might be -1, which we should ignore1 files changed, 1 insertions(+), 1 deletions(-)
http://git.horde.org/horde-git/-/commit/09fdf8b206ceebf097ab3ce2ef8b5b2fe049eb5d
New Attachment: tmp.patch
make the necessary changes. Could you test and make sure I
transferred the changes correctly?
I think that it should be sent to dev (or the appropriate place), a
message to warn people that starting to use this code will bring
unexpected results if they have large objects on memcache.
We have made (untested yet) for ourselves a temporary patch to convert
old large objects to the new flag system. Attached the temp patch
State ⇒ Feedback
Assigned to Michael Slusarz
make the necessary changes. Could you test and make sure I
transferred the changes correctly?
Request #10123: Use memcache flags to keep track of large objectsSigned-off-by: Michael M Slusarz <slusarz@curecanti.org>
2 files changed, 37 insertions(+), 58 deletions(-)
http://git.horde.org/horde-git/-/commit/63dee150d1309f6909b6d3102c68a0f1b3c64d7b
New Attachment: 0001-Use-memcache-flags-to-keep-track-of-large-objects.patch
Priority ⇒ 1. Low
State ⇒ New
Patch ⇒ No
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ Use memcache flags to keep track of large objects
Type ⇒ Enhancement
http://lists.horde.org/archives/dev/Week-of-Mon-20110523/026224.html