Summary | Portal button does nothing in Dimp iframe mode |
Queue | IMP |
Queue Version | 5.0.3 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | ralf.lang (at) ralf-lang (dot) de |
Created | 05/17/2011 (5176 days ago) |
Due | |
Updated | 06/30/2011 (5132 days ago) |
Assigned | 05/17/2011 (5176 days ago) |
Resolved | 06/02/2011 (5160 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
Use a different element id, to not trigger the iframe loading again
(
Bug #10092).2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/587a54f9091a73466775cb8781c886c2fd2b7e3d
Highlight portal entry, not prefs (
Bug #10092).2 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/d1482fae378f220385e9d5223ae55c8afa68fc7f
non-ajax applications is on the agenda for Horde 5.
instead of Portal, User Preferences will be highlighted yellow.
State ⇒ Resolved
non-ajax applications is on the agenda for Horde 5.
Bug #10092: Readd code to view portal, even though it is still disabled2 files changed, 10 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/c16a6e31fb0b95aca5a9265916f8f49d50c27d65
Bug #10092: Readd code to view portal, even though it is still disabled2 files changed, 10 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/c16a6e31fb0b95aca5a9265916f8f49d50c27d65
menu) there is also a problem when users click on imp sub menu
points, like folders. Imp won't check if ajax is available and will
directly go to traditional view.
NOT by hacking around in a single application.
correctly with iframes on. And I'm not sure we can realistically
make it work either without adding a bunch of hackish code. The
problem is that any link within the iframe that eventually opens up
IMP again (e.g. the newmail folder summary) will cause IMP to be
fully reloaded within the IFRAME. So you end up with 2 sidebars.
code embedded in the portal view code that would attempt to workaround
the living in an IFRAME issue. Not only was the code not 100%
reliable, but it was also necessarily removed when the portal code
moved to horde because it was completely dimp specific.
hackishly put together. We had an opportunity to standardize this for
Horde 4, but nobody was interested. Therefore, my belief is that it
isn't appropriate to keep around if it isn't working correctly.
correctly with iframes on. And I'm not sure we can realistically
make it work either without adding a bunch of hackish code. The
problem is that any link within the iframe that eventually opens up
IMP again (e.g. the newmail folder summary) will cause IMP to be
fully reloaded within the IFRAME. So you end up with 2 sidebars.
installation, including non-horde tools.
Apart from user experience of changing navigation (horde menu, imp
menu) there is also a problem when users click on imp sub menu points,
like folders. Imp won't check if ajax is available and will directly
go to traditional view.
work correctly with iframes on. And I'm not sure we can
realistically make it work either without adding a bunch of hackish
code. The problem is that any link within the iframe that
eventually opens up IMP again (e.g. the newmail folder summary) will
cause IMP to be fully reloaded within the IFRAME. So you end up
with 2 sidebars.
entirely? It doesn't work properly, and won't ever work properly,
unless the proper framework is implemented in Horde (*NOT* IMP).
Until that happens, it is going to be prohibitively difficult to try
to support.
SAPO (and makes sense for everyone using IMP, or Kronolith for that
matter, as the main application) to stay in the ajax view when
displaying other non-ajax Horde apps.
Bug #10092: Disable portal when using iframes1 files changed, 0 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/09743e7ccea20e0e476d9485f8f015145b1e53b1
to see the iframe mode go away. I personally am not willing to fix
portal with iframes since I don't have the time.
Bug #10092: Disable portal when using iframes1 files changed, 0 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/09743e7ccea20e0e476d9485f8f015145b1e53b1
http://bugs.horde.org/ticket/9713
* The dimpbase.go event is triggered on click on preferences or on
any mail folder but not on Portal.
* Linking horde as an app and clicking that link works
However this part you are not going to like - the Portal doesn't work
correctly with iframes on. And I'm not sure we can realistically make
it work either without adding a bunch of hackish code. The problem is
that any link within the iframe that eventually opens up IMP again
(e.g. the newmail folder summary) will cause IMP to be fully reloaded
within the IFRAME. So you end up with 2 sidebars.
Which begs the question - why don't we just get rid of iframe
entirely? It doesn't work properly, and won't ever work properly,
unless the proper framework is implemented in Horde (*NOT* IMP).
Until that happens, it is going to be prohibitively difficult to try
to support.
<a href="/horde/services/portal/" accesskey="P"><span
class="accessKey">P</span>ortal</a>
Posted about that earlier, maybe there is a connection to the other issues?
http://bugs.horde.org/ticket/9713
<a href="/horde/services/portal/" accesskey="P"><span
class="accessKey">P</span>ortal</a>
link in iframe mode
imp/js/dimpbase.js doesn't provide an access key portal although the
documentation comment says so.
for this analysis - accesskeys are handled by
horde/js/accesskeys.js). This has been fixed.
trigger actions) is not what I meant.
In iframe mode, clicking the Portal button or pressing alt-P both
doesn't do anything - even after the patch.
In no-iframe mode, clicking the portal button brings back to horde.
State ⇒ Feedback
link in iframe mode
imp/js/dimpbase.js doesn't provide an access key portal although the
documentation comment says so.
this analysis - accesskeys are handled by horde/js/accesskeys.js).
This has been fixed.
Bug #10092: Fix portal accesskey in dynamic mode1 files changed, 2 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/dd98e21d65dff9d2b3ce35743fc195e1d471cd5f
button neither shows the horde portal nor dimp's portal as seen on
H3. It does nothing.
In no iframe mode, it shows the horde portal.
imp/template/dimp/index.inc defines the id appportal for the portal
link in iframe mode
imp/js/dimpbase.js doesn't provide an access key portal although the
documentation comment says so.
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Portal button does nothing in Dimp iframe mode
Type ⇒ Bug
Queue ⇒ IMP
button neither shows the horde portal nor dimp's portal as seen on H3.
It does nothing.
In no iframe mode, it shows the horde portal.
This has been tested in Firefox 4.0.1
Does dimp portal use a separate config? I didn't find a preference or
conf file like H3 dimp's previous config/portal.php
I did not notice any error log or javascript error message.
Please give me instructions on how I can help debugging this. Alternatively,
the test scenario can be downloaded here.
http://susegallery.com/a/BZ4vzQ/kde4-horde4-demo-setup