Maybe a wording can be adjusted then. Something like "Available 
address books:" instead of "Address books that won't be displayed:".

This is by design.  If there are no address books at all selected (the 
default), then ALL address books are displayed. Otherwise, there would 
be nothing in the Turba UI to see at all.

I ment "on the right" here.

Sadly I don't have old data anymore. But these integer values are from 
turba_shares/turba_sharesng table column share_id. So maybe there is 
something wrong in _updateShareName ? As far as I can tell it is the 
only place where these values can be returned.

Anyway, I have purged all 'addressbooks' preferences to see if the 
problem would appear again.

By the way, there is an inconsistency in Turba GUI. Under Address 
Books preferences addressbook list on the left says "Address books 
that will not be displayed:" and this list is populated with all 
available address books by default. The list on the left says "These 
address books will display in this order:". It is empty. However all 
available address books are displayed by default. Even if the user 
re-saves with all addressbooks on the left, they all are displayed 
everywhere.

When did this entry get added? I have no idea where that numeric value 
would have come from. It's not a valid horde 3 value, nor a valid 
horde 4 value for the addressbooks pref.

Well, the upgrade task wouldn't produce those values. So if it ran, 
something went *really* wrong. If it didn't run, those values are 
corrupt anyway. You will have to track this down in 
Turba_LoginTasks_SystemTask_Upgrade#_upgradeAbookPrefs() with a fresh 
set of unupdated data and see what the values are at different points 
along the process.

OK, I found out that this is not related to add_source preference. I 
deleted all add_sources which point to 'localsql'. I have also 
configured a hook to choose default address book in imp for adding 
addresses automatically.

I have added:
Horde::logMessage(var_export($lines, true) . " user: ". 
$GLOBALS['registry']->getAuth(), 'ERR');

under if (!empty($lines)) on line 67 in Turba.php and got the 
following output on failling users:

2011-08-02T01:26:06+03:00 ERR: HORDE [turba] 345 user: martas@lnk.lt 
[pid 15040 on line 68 of "/var/www/html/horde/turba/lib/Turba.php"]
2011-08-02T01:26:06+03:00 WARN: HORDE [turba] PHP ERROR: Invalid 
argument supplied for foreach() [pid 15040 on line 70 of 
"/var/www/html/horde/turba/lib/Turba.php"]

When looking into database I see that this user somehow got new line 
into his preference:
mysql> select * from horde_prefs where pref_uid = 'martas@lnk.lt' and 
pref_name = 'addressbooks';
+---------------+------------+--------------+------------+
| pref_uid      | pref_scope | pref_name    | pref_value |
+---------------+------------+--------------+------------+
| martas@lnk.lt | turba      | addressbooks |
345       |
+---------------+------------+--------------+------------+
1 row in set (0.00 sec)

Also I'm not sure, but there are other users who have 'addressbooks' 
set to simple numbers from ~250 to ~400.

mysql> select * from horde_prefs where pref_name = 'addressbooks' and 
pref_value LIKE '____';
+--------------------------+------------+--------------+------------+
| pref_uid                 | pref_scope | pref_name    | pref_value |
+--------------------------+------------+--------------+------------+
| kitokie@lnk.lt           | turba      | addressbooks |
388       |
| raimonda@lnk.lt          | turba      | addressbooks |
350       |
| simkus@lnk.lt            | turba      | addressbooks |
330       |
| daugirdaite@lnk.lt       | turba      | addressbooks |
332       |

..........

Seems like upgrade task problem to me. No?

Yes, I know that, I was reffering to the same error messages in 
posters log file as mine.

This isn't related to IMP's pref at all...and that pref did not need 
any conversion going from recent H3 to H4 at all.

There is at least one more user on the list with the same errors: 
http://lists.horde.org/archives/horde/Week-of-Mon-20110516/040864.html

(message is not exactlty about my problem, but you can see the same 
errors in the log)

OK. Is there a way to set this preference for all users? Or should I 
just delete it completely and IMP will recreate it automatically? 
Also, what it should be set in imp/config/prefs.local.php ? I want 
user's address book to be the default to add addresses to.

Because it saves the new, correct identifiers for the address book(s).

and keeps all
Yes, because it's IMP's preference that did not contain the correct value.
Why? It's the preference telling IMP which address book to use to add 
email addresses to. Why should Turba create a new address book if that 
preference isn't set correctly?

Then I don't understand why re-saving preferences works and keeps all 
old addresses and address books. More over, old address books are 
accessable through Turba, it's just IMP which doesn't save addresses 
to it on send.

If preferences are corrupt, shouldn't Horde just create completely new 
address book?

These are not valid values for this preference from any recent Horde 3 
version. Closing ticket as this was probably just stale or corrupt 
values going into the upgrade.

Yes I were using shares.

BTW, this is an upgrade from Horde 3 CVS which always was kept up to 
date with HEAD until ~2008 06 and worked fine.

Were you using shares before the upgrade as well? Or did you switch 
this after moving to Horde 4? The 'localsql' value in the prefs looks 
like it wasn't using shares, or was using a very early implementation 
of them...

Before the upgrade:

imp search_sources is empty
imp add_source localsql
turba addressbooks user@example.com

And after I upgrade and re-save:

imp search_sources ["295f46b5435cad5c0dad66a9dc763a71"]
imp add_source 295f46b5435cad5c0dad66a9dc763a71
turba addressbooks ["","295f46b5435cad5c0dad66a9dc763a71"]

Not seeing this.

Can you provide the pre-upgrade value of the pref in question, and the 
post-upgrade value?

H3 -> H4 upgrade seem doesn't migrate prefered address book for adding 
addresses in IMP. After the upgrade every time when a user sends a 
message I get:

2011-04-28T14:30:41+03:00 WARN: HORDE [turba] PHP ERROR: Invalid 
argument supplied for foreach() [pid 13925 on line 149 of 
"/var/www/html/horde/turba/lib/Turba.php"]

Also IMP interface shows "Could not find address book "localsql"" 
notifications when sending a message.

Going into IMP preferences and readjusting address books solves the problem.

I'm using localsql source with shares enabled. Also there are some 
other globally shared address books from one user.