Tickets :: [#28] No icons are being displayed in chora due to bug in MIME

Summary	No icons are being displayed in chora due to bug in MIME_Viewer::getIcon
Queue	Horde Framework Packages
Type	Bug
State	Resolved
Priority	1. Low
Owners
Requester	eddie (at) omegaware (dot) com
Created	03/23/2004 (7723 days ago)
Due
Updated	03/24/2004 (7722 days ago)
Assigned
Resolved	03/24/2004 (7722 days ago)
Milestone
Patch	No

03/24/2004 10:50:24 PM	Jan Schneider	Comment #2 State ⇒ Resolved	Reply to this comment
Fixed in CVS already, but thanks for your patch!

03/23/2004 08:35:28 PM		New Attachment: mime_viewer.diff

03/23/2004 08:32:27 PM	eddie (at) omegaware (dot) com	Comment #1 State ⇒ Unconfirmed Priority ⇒ 1. Low Type ⇒ Bug	Reply to this comment
I have the global horde $mime_drivers array setup and configured with icons, and nothing in the chora mime_drivers.php.. Vieweing of a .c file calls the appropriate mime viewer (enscript), but in the directory view there are no icons for Chora.. I've tracked down the problem to line 394 of MIME/Viewer.php where the _getIcon function returns null because $mime_drivers['chora'] is not set.. Shouldn't the getIcon function also check for the 'horde' application if 'chora' does not have any settings? It looks like code is in there to do that, but it is not working due to $ob being set to null for the compare in getIcon.