Tickets :: [#11785] RTL bugs in horde

6.0.0-alpha10

5/14/25

Summary	RTL bugs in horde
Queue	Horde Framework Packages
Queue Version	Git master
Type	Bug
State	Stalled
Priority	1. Low
Owners
Requester	esr+hord-bugs (at) g (dot) jct (dot) ac (dot) il
Created	11/29/2012 (4549 days ago)
Due
Updated	01/15/2013 (4502 days ago)
Assigned	11/30/2012 (4548 days ago)
Resolved	01/15/2013 (4502 days ago)
Milestone
Patch	No

01/15/2013 06:10:56 PM	Jan Schneider	State ⇒ Stalled

11/30/2012 04:11:53 PM	Git Commit	Comment #3	Reply to this comment
Changes have been made in Git (master): commit 7c38874fa4c93972035a7d07bdbf3f88312903c5 Author: Jan Schneider <jan@horde.org> Date: Fri Nov 30 16:28:57 2012 +0100 Set a few styles dependent on RTL (~~Bug #11785~~). horde/lib/View/Sidebar.php \| 2 + horde/templates/sidebar/sidebar.html.php \| 2 +- horde/themes/default/rtl.css \| 122 +++++++++++++----------------- horde/themes/default/screen.css \| 5 - kronolith/templates/dynamic/index.inc \| 2 +- 5 files changed, 57 insertions(+), 76 deletions(-) http://git.horde.org/horde-git/-/commit/7c38874fa4c93972035a7d07bdbf3f88312903c5

11/30/2012 03:31:47 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
[Show Quoted Text - 13 lines][Hide Quoted Text] When viewing horde in RTL mode (hebrew/arabic) the layout breaks terribly, I jave started identifying some problems but since I am not familiar with the framework I don't necisarrily know how to solve them. One problem is some inline stile that assumes LTR languages: # grep -R 'style="left:' /usr/share/horde4/ /usr/share/horde4/templates/sidebar/sidebar.html.php:<div id="horde-slideleft" class="horde-splitbar-vert" style="left:<?php echo $this->width ?>px"> /usr/share/horde4/kronolith/templates/dynamic/index.inc:<div id="horde-page" style="left:<?php echo $prefs->getValue('sidebar_width') ?>px"> Fixed, though this doesn't change the layout of course. There's much more to do. /usr/share/horde4/kronolith/templates/fbview/busyblock.html:<td><div class="kronolithFBBusy" style="left:<tag:left />;width:<tag:width />;"> </div></td> /usr/share/horde4/kronolith/templates/fbview/meetingblock.html:<td><div class="kronolithFBFree" style="left:<tag:left />;width:<tag:width />;"> </div></td> I left those out, because this also requires the fb table to be rendered RTL. Or is it? [Show Quoted Text - 11 lines][Hide Quoted Text] In the above examples a direction check should have been done and in the case of RTL they should have read: style="right:<?php echo $this->width ?>px" I realize some of these are part of the kronolith project and not horde at large, if you so prefer I will open a seperate bug for them. In screen.css there are also several parameters that should be direction dependent, I still need to sit down longer to identify them all but as a start: #horde-page has a padding that should be direction dependent. Fixed. RTL specific changes go to rtl.css. Please note that I already updated it a bit, so make sure you work against a Git version of Horde.

11/29/2012 05:58:21 PM	esr+hord-bugs (at) g (dot) jct (dot) ac (dot) il	Comment #1 Priority ⇒ 1. Low Patch ⇒ No Milestone ⇒ Queue ⇒ Horde Framework Packages Summary ⇒ RTL bugs in horde Type ⇒ Bug State ⇒ Unconfirmed	Reply to this comment
When viewing horde in RTL mode (hebrew/arabic) the layout breaks terribly, I jave started identifying some problems but since I am not familiar with the framework I don't necisarrily know how to solve them. One problem is some inline stile that assumes LTR languages: # grep -R 'style="left:' /usr/share/horde4/ /usr/share/horde4/templates/sidebar/sidebar.html.php:<div id="horde-slideleft" class="horde-splitbar-vert" style="left:<?php echo $this->width ?>px"> /usr/share/horde4/kronolith/templates/dynamic/index.inc:<div id="horde-page" style="left:<?php echo $prefs->getValue('sidebar_width') ?>px"> /usr/share/horde4/kronolith/templates/fbview/busyblock.html:<td><div class="kronolithFBBusy" style="left:<tag:left />;width:<tag:width />;"> </div></td> /usr/share/horde4/kronolith/templates/fbview/meetingblock.html:<td><div class="kronolithFBFree" style="left:<tag:left />;width:<tag:width />;"> </div></td> In the above examples a direction check should have been done and in the case of RTL they should have read: style="right:<?php echo $this->width ?>px" I realize some of these are part of the kronolith project and not horde at large, if you so prefer I will open a seperate bug for them. In screen.css there are also several parameters that should be direction dependent, I still need to sit down longer to identify them all but as a start: #horde-page has a padding that should be direction dependent.