This was my last version of the maintenance rewrite, I only add it to 
have it archived. Maybe it might be of some use some time in the future.

Agreed - the code is horribly obfuscated.  I think this was the first 
big item I wrote for Horde before I was a developer.  I'm not sure how 
I got CVS access after this (maybe it was because no one else 
understands the code :) )  But it has been in the codebase for 2-3 
years so ripping it out before the next release doesn't seem to make 
sense, to me at least.

The point is that the current code is hard to maintain and overly 
complicated. But I gave up rewriting this without retarding the 
release even more.



I get the frameset after logging in, not before, and I get the 
maintenance directly after logging in. Loading the frameset is fixed 
now, as well as being able to login at all.



I still get redirected to IMP instead of the preferred application 
after running maintenances, and the maintenance tasks are skipped if I 
simply reload the confirm page, rendering the agree maintenance type 
useless. But these are no showstoppers for the release anymore.

Maintenance done - IMP is loaded.

Maintenance screen 2.

Click on IMP.  Imp runs maintenance tasks (I have set up my system to 
run 2 - a TOS agreement and purge trash).  This is task screen 1.

Login to Horde.

I'm really confused by this.  The maintenance code works fine for me, 
and I don't believe there is any reason to rewrite the code.  Attached 
you will find screenshots of a session where maintenance tasks get 
performed.

Looking at the maintenance code, I think this is really something that 
shouldn't get shipped with Horde 3.0. I have no idea if we will be 
able to fix this in time, but here is what I got for today, maybe 
someone understands where I'm heading and can complete this. Otherwise 
I'll try to finish this tomorrow.

Didn't help, and now the maintenance tasks aren't executed anymore at 
all. I'm really having a hard time to trace this code, but I'll keep 
trying to fix this.

I move the processing code further up in the file to prevent reaching 
any of the code that would cause the undefined errors - it seems to be 
working for my test cases.

I hit the else clause in line 131 because $server_key is empty at this time.

No. Instead I can't login anymore at all and get the following warning 
twice before the page gets redirected back to imp/login.php:

Notice: Undefined variable: sessArray in 
/home/jan/headhorde/imp/redirect.php on line 137



Using application/imp auth.

Try what I just committed.

Sorry Michael, I still can't follow the Maintenance code to figure out 
where URLs are generated.

The frameset isn't loaded anymore after running the maintenance tasks, 
and the initial_application pref isn't honoured either.