[#993] No frameset after maintenance
Summary No frameset after maintenance
Queue Horde Base
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners Michael Slusarz <slusarz (at) horde (dot) org>
Requester Jan Schneider <jan (at) horde (dot) org>
Created 12/18/2004 (1359 days ago)
Due
Updated 01/14/2005 (1332 days ago)
Assigned 12/19/2004 (1358 days ago)
Resolved 01/14/2005 (1332 days ago)
Attachments login_screen.png Download
imp.png Download
maintenance2.diff Download
maintenance.diff Download
maintenance_1.png Download
maintenance_2.png Download
Milestone
Patch No

History
01/14/2005 Jan Schneider Comment #16
State ⇒ Resolved
New Attachment: maintenance2.diff Download		 Reply to this comment
This was my last version of the maintenance rewrite, I only add it to 
have it archived. Maybe it might be of some use some time in the future.
12/22/2004 Michael Slusarz Comment #15 Reply to this comment
Agreed - the code is horribly obfuscated.  I think this was the first 
big item I wrote for Horde before I was a developer.  I'm not sure how 
I got CVS access after this (maybe it was because no one else 
understands the code :) )  But it has been in the codebase for 2-3 
years so ripping it out before the next release doesn't seem to make 
sense, to me at least.
12/22/2004 Jan Schneider Comment #14 Reply to this comment
The point is that the current code is hard to maintain and overly 
complicated. But I gave up rewriting this without retarding the 
release even more.

I get the frameset after logging in, not before, and I get the 
maintenance directly after logging in. Loading the frameset is fixed 
now, as well as being able to login at all.

I still get redirected to IMP instead of the preferred application 
after running maintenances, and the maintenance tasks are skipped if I 
simply reload the confirm page, rendering the agree maintenance type 
useless. But these are no showstoppers for the release anymore.
12/21/2004 Michael Slusarz Comment #13
New Attachment: imp.png Download		 Reply to this comment
Maintenance done - IMP is loaded.
12/21/2004 Michael Slusarz Comment #12
New Attachment: maintenance_2.png Download		 Reply to this comment
Maintenance screen 2.
12/21/2004 Michael Slusarz Comment #11
New Attachment: maintenance_1.png Download		 Reply to this comment
Click on IMP.  Imp runs maintenance tasks (I have set up my system to 
run 2 - a TOS agreement and purge trash).  This is task screen 1.
12/21/2004 Michael Slusarz Comment #10
New Attachment: login_screen.png Download		 Reply to this comment
Login to Horde.
12/21/2004 Michael Slusarz Comment #9 Reply to this comment
I'm really confused by this.  The maintenance code works fine for me, 
and I don't believe there is any reason to rewrite the code.  Attached 
you will find screenshots of a session where maintenance tasks get 
performed.
12/21/2004 Jan Schneider Comment #8
New Attachment: maintenance.diff Download		 Reply to this comment
Looking at the maintenance code, I think this is really something that 
shouldn't get shipped with Horde 3.0. I have no idea if we will be 
able to fix this in time, but here is what I got for today, maybe 
someone understands where I'm heading and can complete this. Otherwise 
I'll try to finish this tomorrow.
12/21/2004 Jan Schneider Comment #7 Reply to this comment
Didn't help, and now the maintenance tasks aren't executed anymore at 
all. I'm really having a hard time to trace this code, but I'll keep 
trying to fix this.
12/20/2004 Michael Slusarz Comment #6 Reply to this comment
I move the processing code further up in the file to prevent reaching 
any of the code that would cause the undefined errors - it seems to be 
working for my test cases.
12/20/2004 Jan Schneider Comment #5 Reply to this comment
I hit the else clause in line 131 because $server_key is empty at this time.
12/20/2004 Jan Schneider Comment #4 Reply to this comment
No. Instead I can't login anymore at all and get the following warning 
twice before the page gets redirected back to imp/login.php:
Notice: Undefined variable: sessArray in 
/home/jan/headhorde/imp/redirect.php on line 137

Using application/imp auth.
12/19/2004 Michael Slusarz Comment #3 Reply to this comment
Try what I just committed.
12/19/2004 Chuck Hagenbuch Comment #2
Assigned to Michael Slusarz
State ⇒ Assigned		 Reply to this comment
Sorry Michael, I still can't follow the Maintenance code to figure out 
where URLs are generated.
12/18/2004 Jan Schneider Comment #1
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ No frameset after maintenance
Queue ⇒ Horde Base		 Reply to this comment
The frameset isn't loaded anymore after running the maintenance tasks, 
and the initial_application pref isn't honoured either.