[#8376] vacation allows empty subject/reason
| Summary | vacation allows empty subject/reason |
| Queue | Ingo |
| Queue Version | 1.2.1 |
| Type | Enhancement |
| State | Resolved |
| Priority | 1. Low |
| Owners | Michael Slusarz <slusarz (at) horde (dot) org> |
| Requester | crohmann (at) netcologne (dot) de |
| Created | 06/25/2009 (1424 days ago) |
| Due | |
| Updated | 01/24/2013 (115 days ago) |
| Assigned | 06/28/2009 (1421 days ago) |
| Resolved | 01/24/2013 (115 days ago) |
| Attachments | vacation_must_subject_reason.diff  |
| Milestone | |
| Patch | Yes |
History
State ⇒ Resolved
Taken from
Assigned to Michael Slusarz
commit faf21c14a3a43cfb556320bbcb15cc0ba9182156
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jan 23 18:06:28 2013 -0700
[mms] Require non-empty subject and reason fields when creating a
vacation message (crohmann@netcologne.de;
Request #8376).ingo/docs/CHANGES | 2 ++
ingo/lib/Form/Vacation.php | 4 ++--
ingo/package.xml | 2 ++
3 files changed, 6 insertions(+), 2 deletions(-)
http://git.horde.org/horde-git/-/commit/faf21c14a3a43cfb556320bbcb15cc0ba9182156
Assigned to
State ⇒ New
New Attachment: vacation_must_subject_reason.diff
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Ingo
Summary ⇒ vacation allows empty subject/reason
Type ⇒ Enhancement
Priority ⇒ 1. Low
entering ANY information. This leads to unwanted mail junk without the
user even noticing.
The attached patch sets the fields "subject" and "reason" as MUST enter.
One might argue that now there always has to be text in those fields
even though the rule is not enabled. Otherwise there had to be more
code to check for things, this patch does not change much.