6.0.0
7/2/26

[#4107] Don't show all types on search.php
Summary Don't show all types on search.php
Queue Whups
Type Enhancement
State Resolved
Priority 1. Low
Owners
Requester tinu (at) humbapa (dot) ch
Created 7/3/06 (7304 days ago)
Due
Updated 7/5/07 (6937 days ago)
Assigned
Resolved 7/5/07 (6937 days ago)
Milestone
Patch No

History
284 Chuck Hagenbuch Comment #7
State ⇒ Resolved
Reply to this comment
Alright, I'm convinced. Committed, thanks.
403 Chuck Hagenbuch Deleted Original Message
 
167 tinu (at) humbapa (dot) ch Comment #6 Reply to this comment
the following code:



$a1 = array(1=>'a', 2=>'b');

$a2 = array(1=>'a', 2=>'c', 3=>'d');

print_r($a1+$a2);



outputs: Array ( [1] => a [2] => b [3] => d )

"+" only merge entries if the key doesn't already exists.
129 Chuck Hagenbuch Comment #5 Reply to this comment
Doesn't this duplicate types that are used in more than one (visible) queue?
it should not: The + operator appends the right handed array to the
left handed, whereas duplicated keys are NOT overwritten. (from
http://www.php.net/manual/en/language.operators.array.php)
Duplicate keys not being overwritten means that they _are_ duplicated...
5410 tinu (at) humbapa (dot) ch Comment #4
New Attachment: Search.php.patch2.txt Download
Reply to this comment
sorry I somehow forgot this ticket...
Doesn't this duplicate types that are used in more than one (visible) queue?
it should not: The + operator appends the right handed array to the 
left handed, whereas duplicated keys are NOT overwritten. (from 
http://www.php.net/manual/en/language.operators.array.php)



I attached a new patch so it will work with the new whups-driver-name 
($whups_driver).
187 Chuck Hagenbuch Comment #3
State ⇒ Rejected
Reply to this comment
No feedback.
303 Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
Doesn't this duplicate types that are used in more than one (visible) queue?
37 tinu (at) humbapa (dot) ch Comment #1
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Don't show all types on search.php
Queue ⇒ Whups
New Attachment: search.php.patch
State ⇒ New
Reply to this comment
this little patch modifies search.php so that only the types according 
to the shown queues are visible.

e.g. on my setup guest users are not allowed to access all queues, so 
I don't want to show them types they don't need.

thanks!

Saved Queries