Tickets :: Comment on [#1434] phishing warning

* Your Email Address
* Spam protection	Enter the letters below: __ .__..__ .___. __. / `[__][__) \| (__ \__.\| \|[__) \| .__)
Comment	> This looks good as a first glance. I have some suggestions though: > > > > - In the first two preg_match calls, why do you expect a whitespace > like 'href= http://...' if the href attribute is not enclosed in > quotes? \|\s+ should probably be \|\s* > > - You should use MIME_Contents::formatStatusMessage() for showing the > phishing warnings, see imp/lib/MIME/Viewer/html.php for examples. It > might also be a good thing to extend this method to also accept an > optional class name for the status box. That wouldn't break BC and > allows to show boxes that look more like warnings like the current > ones that even have a fixed style. > > - The message could probably be tweaked to sound less diffuse. But > that could be done later. But at least it has to be a gettext message.
Attachment
Watch this ticket