6.0.0-beta1
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
1/8/26
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#8079] Avoid notice in _removeBr from Text_Filter/Filter/highlightquotes.php
*
Your Email Address
*
Spam protection
Enter the letters below:
.__ .___..___ __..__ [ __ | [__ (__ [__) [_./ | | .__)| \
Comment
>> How about my patch, which removes for() loops entirely? > > > > Looks also fine to me. > > > > Instead of: > > foreach (array_keys($lines) as $i) { > > You could use: > > foreach ($lines as $i => $line) { > > if (!preg_match("/^\s*<br\s*\/>\s*$/i", $line)) { > > ... > > > > To eliminate the extra array_keys() call. > > But at the end its the same. > > Your new approach is _technically seen_ maybe a little more > expensive, but it does indeed remove the "unnice" for() loop. > > > > I am fine either. > > > > - Jens > >
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers