Tickets :: Comment on [#11775] syncml fails

* Your Email Address
* Spam protection	Enter the letters below: \ /.___.__ __.\ / >< [__ \| \(__ >< / \\| \|__/.__)/ \
Comment	> This patch is just curing symptoms. The question is, why does $uri at > that point already have a version attached, and why doesn't it match > the version in $this->_wbxmlVersion? > > setVersion() indeed looks broken though. Did you try if only changing > that method already fixes the double version number? > >> Can anyone review/test the patch I proposed in the earlier comment? >> Syncml broke again for my blackberry/syncje after a "pear upgrade". >> "Unable to find dtd for syncml:syncml1.11.2" >> >> Thanks >> >>> --- Horde/Xml/Wbxml/Encoder.php.orig Wed Oct 31 10:24:43 2012 >>> +++ Horde/Xml/Wbxml/Encoder.php Fri Nov 30 10:02:21 2012 >>> @@ -95,15 +95,8 @@ >>> public function writeHeader($uri) >>> { >>> // @todo: this is a hack! >>> - if ($this->_wbxmlVersion == 2 && !preg_match('/1\.2$/', $uri)) { >>> - $uri .= '1.2'; >>> - } >>> - if ($this->_wbxmlVersion == 1 && !preg_match('/1\.1$/', $uri)) { >>> - $uri .= '1.1'; >>> - } >>> - if ($this->_wbxmlVersion == 0 && !preg_match('/1\.0$/', $uri)) { >>> - $uri .= '1.0'; >>> - } >>> + if (!preg_match('/1\.[0-9]$/', $uri)) >>> + $uri .= '1.' . $this->_wbxmlVersion; >>> >>> $this->_dtd = $this->_dtdManager->getInstanceURI($uri); >>> >>> >>> --- Horde/Xml/Wbxml/ContentHandler.php.orig Wed Oct 31 10:24:43 2012 >>> +++ Horde/Xml/Wbxml/ContentHandler.php Fri Nov 30 09:58:31 2012 >>> @@ -51,7 +51,7 @@ >>> >>> public function setVersion($v) >>> { >>> - $this->_wbxmlVersion = 2; >>> + $this->_wbxmlVersion = $v; >>> } >> >> >
Attachment
Watch this ticket

Saved Queries