Tickets :: Comment on [#2782] S/MIME Sign using browser capabilities

* Your Email Address
* Spam protection	Enter the letters below: .___.__.. ..__. __ [__ \| \|\|\ \|[__]/ ` \| \|__\|\| \\|\| \|\__.
Comment	> I am refactoring the code to minimize changes. > > My goal now is to keep original openssl signature implementation > untainted, as well as providing the new browser signing feature. > > The patch has no major changes, only refactoring. > > I said before my idea is to extend IMP, not to change code. So I > created a new class IMP_SMIME_Delegate_Encryption extending IMP_SMIME > that makes no use of openssl. Instead, it just uses the signature > passed from the web form and set into this new object. > > I had to extract some functionality from superclass > Horde_Crypt_smime::signMIMEPart() into a new method > Horde_Crypt_smime::wrapMessageInSMIME() so it could be called from > the new class. > > I guess the new class's name is awful. I would appreciate any > suggestion of a better name for it. > > I attach horde-imp-signing-2.patch > > There is a lot more to do regarding functionality, but I want to > clean up this code first while it's still small. > > As usual, any comments are welcome! > > > > Mariano.
Attachment
Watch this ticket