6.0.0-git
2019-03-23

[#5629] aspell + html composition == no spell check
Summary aspell + html composition == no spell check
Queue IMP
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners chuck (at) horde (dot) org
Requester dimante (at) dimante (dot) net
Created 2007-08-13 (4240 days ago)
Due
Updated 2007-08-30 (4223 days ago)
Assigned 2007-08-30 (4223 days ago)
Resolved 2007-08-30 (4223 days ago)
Milestone
Patch No

History
2007-08-30 02:17:00 Chuck Hagenbuch Comment #30
Assigned to Chuck Hagenbuch
Taken from Horde DevelopersHorde Developers
State ⇒ Resolved
Reply to this comment
2007-08-30 01:43:18 dimante (at) dimante (dot) net Comment #29 Reply to this comment
Okay, the URL problem only applies when HTML composition is on.
I'm sorry I should have specified that :-(


2007-08-30 01:41:51 Chuck Hagenbuch Comment #28
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
Reply to this comment
Okay, the URL problem only applies when HTML composition is on.
2007-08-30 01:41:50 dimante (at) dimante (dot) net Comment #27 Reply to this comment
I have a signature with a URL in it that does not exhibit this
problem; I also pasted your signature into a compose window and it
worked fine, and to make sure, I saved it as my default signature and
tried spellchecking and it still worked fine.
I sent you an email.  When you paste a url in the editor it does not 
automatically wrap the <a> tags around it and yes it does spell check 
fine.  You will see on the example that I set up for you that when it 
comes in as a signature it actually hyperlinks and I think that has 
something to do with it.


2007-08-30 01:28:01 Chuck Hagenbuch Comment #26 Reply to this comment
I have a signature with a URL in it that does not exhibit this 
problem; I also pasted your signature into a compose window and it 
worked fine, and to make sure, I saved it as my default signature and 
tried spellchecking and it still worked fine.
2007-08-30 01:09:01 dimante (at) dimante (dot) net Comment #25 Reply to this comment
Sorry to be a pest but I have a root cause for the "Spell Check Does 
Not Work" and here it is:



It was the signature containing a URL that caused the spell check to 
hang at checking and never complete:



Signature with spelling hang:

Best Regards,

John Gates

Dimante Computer Services LLC

http://www.dimante.net



Signature where spell check works perfectly:

Best Regards,

John Gates

Dimante Computer Services LLC



I have confirmed this and it is reproducible.  Do you know why a URL 
in a signature would cause this error?



Thanks for working with me 8)

-D-
2007-08-30 00:22:53 dimante (at) dimante (dot) net Comment #24 Reply to this comment

[Show Quoted Text - 20 lines]
If there is no signature for the user at all that error above shows 
up.  If you put even a space in the signature box and save it the 
compose window comes up without error... (And the spell check works). 
So that settles one bug and finds another in the process.  Should I 
submit a new ticket for the above issue?
2007-08-29 23:48:01 dimante (at) dimante (dot) net Comment #23 Reply to this comment
If it's still the javascript error, then open compose.js and put in
debugging statements, see what happens.
Well I do what I normally do when things are not going correctly.  I 
create a new user and see what they are presented.



Here goes:

When I log in as a new user and try to click compose message the 
following error occurs:



Fatal error: Class 'Text_Filter' not found in 
/usr/local/www/horde/imp/compose.php on line 725



Now I can log in right behind this with an established user account 
and the compose window appears no problem.



Now wait it gets even better.  The same new user can view a message 
and then reply with no error (And this uses the same compose.php) so I 
am completely lost here.... Should I start all over and reinstall 
everything?
2007-08-29 22:56:47 Chuck Hagenbuch Comment #22 Reply to this comment
If it's still the javascript error, then open compose.js and put in 
debugging statements, see what happens.
2007-08-29 22:55:15 dimante (at) dimante (dot) net Comment #21 Reply to this comment
No. You need to start tracing exactly what is going on, since no
developer is seeing this.

Are you sure that you're clearing your browser's cache to get the new
javascript in the changes to IMP?
I have firefox clear the cache and all private data everytime I close 
it.  I also tried Safari, IE and Netscape.  I am seeing the problem in 
every browser.  It is very peculiar.  I have never had a problem like 
this before.  What can I do to trace it?
2007-08-29 22:46:38 Chuck Hagenbuch Comment #20 Reply to this comment
No. You need to start tracing exactly what is going on, since no 
developer is seeing this.



Are you sure that you're clearing your browser's cache to get the new 
javascript in the changes to IMP?
2007-08-29 21:54:24 dimante (at) dimante (dot) net Comment #19 Reply to this comment
I installed the framework exactly how the document said to.  HTML 
editor and spell check still do not work.  Is there a framework for 
imp required too?
2007-08-29 17:12:21 dimante (at) dimante (dot) net Comment #17 Reply to this comment
Does the contents of the framework go into the same base Horde/ directory?
2007-08-29 02:15:43 Chuck Hagenbuch Comment #16
State ⇒ Resolved
Reply to this comment
Chuck - you might want to look at it as you made these changes when
doing the HTML signature changes a couple of months ago.  However,
the old version of xinha truly does use the DOM element node as a key
- weird but true.
I just re-tested signature and spell check with the html editor on, 
and things still work at the same rate they did before your changes, 
so I'm going to go ahead and close the ticket.
2007-08-29 00:14:42 Chuck Hagenbuch Comment #15 Reply to this comment
I have been using Horde / IMP since 2000.  I am not saying that you
are completely off base telling me my upgrade is wrong but, I have
replaced all the files in config with the .dist files and I believe
my Horde setup is correct.  I just downloaded the latest snapshots of
Horde and IMP Head.
Ever since Horde 3.0, the Horde Framework libraries and the Horde base 
install have been separated. If you use stable releases everything is 
taken care of for you, but if you are using CVS -or- snapshots, you 
are responsible for downloading the Framework package and installing 
it. If you're not downloading the framework snapshot, OR if you're not 
running install-packages.php or using symlinks to make sure the actual 
files in your include_path are updated, then you're not updating Horde 
fully.
2007-08-28 23:43:05 dimante (at) dimante (dot) net Comment #14 Reply to this comment
These are my versions:

Horde  Horde (horde)  3.2-cvs                      Application is ready.

Mail Mail (imp) H3 (4.2-cvs)                 Application is ready.



I have been using Horde / IMP since 2000.  I am not saying that you 
are completely off base telling me my upgrade is wrong but, I have 
replaced all the files in config with the .dist files and I believe my 
Horde setup is correct.  I just downloaded the latest snapshots of 
Horde and IMP Head.  The changes as your link points to are in the 
files and have updated however the spellchecking is still not working. 
  Not sure what else to do.  If you email I can send a username and 
password so you can see the issue in action.  If you think I have 
mis-configured Horde I would appreciate any feedback you could give as 
to what you think it may be.  Thank you.

[Show Quoted Text - 11 lines]
2007-08-28 18:12:07 Michael Slusarz Comment #13 Reply to this comment
1. I think this should fix things:

  http://cvs.horde.org/diff.php?r1=1.6&r2=1.7&f=imp%2Fjs%2Fsrc%2Fcompose.js



Chuck - you might want to look at it as you made these changes when 
doing the HTML signature changes a couple of months ago.  However, the 
old version of xinha truly does use the DOM element node as a key - 
weird but true.



2. If you truly are still seeing this error (before applying this 
patch), that means that you did not upgrade Horde to 3.2 correctly as 
your error would only occur if you were using IMP 4.2 and Horde < 3.2.
2007-08-22 14:36:14 dimante (at) dimante (dot) net Comment #12 Reply to this comment
I made an additional change:



Horde: 3.2-cvs



I am running horde head (Had some problems with this as I had to add 
to add /usr/local/www/horde/lib:. to my apache path 8()



Problem still exists after this as well.
2007-08-22 14:25:38 dimante (at) dimante (dot) net Comment #11 Reply to this comment
Yes I am really using head: Mail (imp)  H3 (4.2-cvs)

I did did not update since 8/17/2007 because nothing changed in the 
nightly snapshot since then.  I did see that there was a change in 
today's (8/22) snapshot so I installed it.  I do not see the 
Javascript error anymore but the spell checking icon still changes to 
"Checking..." and nothing else happens.  I primarily use Mozilla 
Firefox and this is where I first found this bug.  I have also tried 
(Yuck) IE, Netscape, and Safari (Windows Port) and they all behave the 
same so it not a browser related issue that I can see.  Here are the 
other vitals on my machine:



FreeBSD 6.2-RELEASE #7

aspell-0.60.5_2     Spelling checker with better suggestion logic than ispell

php5-5.2.1_3        PHP Scripting Language (Apache Module and CLI)

php5-bz2-5.2.1_3    The bz2 shared extension for php

php5-calendar-5.2.1_3 The calendar shared extension for php

php5-ctype-5.2.1_3  The ctype shared extension for php

php5-dom-5.2.1_3    The dom shared extension for php

php5-extensions-1.1 A "meta-port" to install PHP extensions

php5-ftp-5.2.1_3    The ftp shared extension for php

php5-gd-5.2.1_3     The gd shared extension for php

php5-gettext-5.2.1_3 The gettext shared extension for php

php5-iconv-5.2.1_3  The iconv shared extension for php

php5-imap-5.2.1_3   The imap shared extension for php

php5-ldap-5.2.1_3   The ldap shared extension for php

php5-mbstring-5.2.1_3 The mbstring shared extension for php

php5-mcrypt-5.2.1_3 The mcrypt shared extension for php

php5-mhash-5.2.1_3  The mhash shared extension for php

php5-mysql-5.2.1_3  The mysql shared extension for php

php5-openssl-5.2.1_3 The openssl shared extension for php

php5-pcre-5.2.1_3   The pcre shared extension for php

php5-pdo-5.2.1_3    The pdo shared extension for php

php5-pdo_sqlite-5.2.1_3 The pdo_sqlite shared extension for php

php5-posix-5.2.1_3  The posix shared extension for php

php5-pspell-5.2.3_1 The pspell shared extension for php

php5-session-5.2.1_3 The session shared extension for php

php5-simplexml-5.2.1_3 The simplexml shared extension for php

php5-spl-5.2.1_3    The spl shared extension for php

php5-sqlite-5.2.1_3 The sqlite shared extension for php

php5-tokenizer-5.2.1_3 The tokenizer shared extension for php

php5-xml-5.2.1_3    The xml shared extension for php

php5-xmlreader-5.2.1_3 The xmlreader shared extension for php

php5-xmlwriter-5.2.1_3 The xmlwriter shared extension for php

php5-zlib-5.2.1_3   The zlib shared extension for php





Horde/test.php



Horde Version



     * Horde: 3.2-ALPHA



Horde Applications



     * Horde: 3.2-ALPHA

     * Imp: H3 (4.2-cvs) (run Imp tests)

     * Ingo: H3 (1.2-cvs) (run Ingo tests)

     * Kronolith: H3 (2.2-cvs) (run Kronolith tests)

     * Mnemo: H3 (2.2-cvs)

     * Nag: H3 (2.1.2)

     * Passwd: H3 (3.0.1-RC1)

     * Turba: H3 (2.1.3)



PHP Version



     * View phpinfo() screen

     * View loaded extensions

     * PHP Version: 5.2.1

     * PHP Major Version: 5.2

     * PHP Minor Version: 1

     * PHP Version Classification: release

     * You are running a supported version of PHP.



PHP Module Capabilities



     * Ctype Support: Yes

     * DOM XML Support: Yes

     * FTP Support: Yes

     * GD Support: Yes

     * Gettext Support: Yes

     * GeoIP Support (via PECL extension): No

       Horde can optionally use the GeoIP extension to provide faster 
country name lookups.

     * Iconv Support: Yes

     * IMAP Support: Yes

     * JSON Support: Yes

     * LDAP Support: Yes

     * LZF Compression Support: No

       If the lzf PECL module is available, Horde can compress some 
cached data in your session to make your session size smaller.

     * Mbstring Support: Yes

     * PCRE Support: Yes

     * PCRE UTF-8 Support: Yes

     * Mcrypt Support: Yes

     * memcached Support (memcache): Yes

     * MIME Magic Support (fileinfo): Yes

     * MIME Magic Support (mime_magic): No

       The fileinfo PECL module (see above) or the mime_magic PHP 
extension will most likely provide faster MIME Magic lookups than the 
built-in Horde PHP magic code. See horde/docs/INSTALL for information 
on how to install PECL/PHP extensions.

     * MySQL Support: Yes

     * OpenSSL Support: Yes

     * PostgreSQL Support: No

       The PostgreSQL extension is only required if you want to use a 
PostgreSQL database server for data storage.

     * Session Support: Yes

     * XML Support: Yes

     * Zlib Support: Yes



Miscellaneous PHP Settings



     * magic_quotes_runtime disabled: Yes

     * memory_limit value: 128M

       If PHP's internal memory limit is not set high enough Horde 
will not be able to handle large data items (e.g. large mail 
attachments in IMP). You should set the value of memory_limit in 
php.ini to a sufficiently high value - at least 64M is recommended.

     * safe_mode disabled: Yes

     * session.use_trans_sid disabled: Yes

     * session.auto_start disabled: Yes

     * zlib.output_compression disabled: Yes

     * zend_accelerator.compress_all disabled: Yes



File Uploads



     * file_uploads enabled: Yes

     * upload_max_filesize: 20M

     * post_max_size: 20M



Required Horde Configuration Files



     * config/conf.php: Yes

     * config/mime_drivers.php: Yes

     * config/nls.php: Yes

     * config/prefs.php: Yes

     * config/registry.php: Yes



PHP Sessions



     * Session counter: 1

     * To unregister the session: click here



PEAR



     * PEAR Search Path (PHP's include_path):   
/usr/local/www/horde/lib:.:/usr/local/lib/php:/usr/local/share/pear:.

     * PEAR: Yes

     * Recent PEAR: Yes

     * Mail: Yes

     * Mail_Mime: Yes

     * Log: Yes

     * DB: Yes

     * Net_Socket: Yes

     * Date: Yes

     * Auth_SASL: Yes

     * HTTP_Request: Yes

     * Net_SMTP: Yes

     * Services_Weather: Yes

     * Cache: Yes

     * XML_Serializer: Yes



Since the javascript error is not occurring anymore then changing the 
path in horde is not going to help us there.  Please let me know what 
else I can provide to help.

[Show Quoted Text - 13 lines]
2007-08-22 03:35:40 Chuck Hagenbuch Comment #10 Reply to this comment
First of all, are you really using HEAD, and if so, have you updated 
it (in the last day - please always cvs up before reporting issues 
with HEAD).



It'd be helpful if you could change your jsuri setting for IMP (in 
horde/config/registry.php) to the js/src/ dir so that you can get a 
real line number (alternatively you can just copy js/src/compose.js to 
js/compose.js temporarily).



What browser and version are you using? Everywhere we use __editors, 
we do a typeof check first to see if it's defined. So if your browser 
is passing that check but it's not defined, it'd be very interesting 
to see what it _is_.
2007-08-21 11:34:39 dimante (at) dimante (dot) net Comment #9 Reply to this comment
Good call Chuck:



Error: __editors is not defined

Source File: http://dimante.net/horde/imp/js/compose.js

Line: 1



That error appears after clicking check spelling.  The button text 
changes to checking but nothing happens.
2007-08-21 02:30:29 Chuck Hagenbuch Comment #8 Reply to this comment
Nothing was attached. Have you checked your javascript console?
2007-08-21 02:17:28 dimante (at) dimante (dot) net Comment #7 Reply to this comment
Here is what I see (See attachment)
2007-08-21 02:11:38 dimante (at) dimante (dot) net Comment #6 Reply to this comment
So you are telling me in HTML composition mode the spell check is 
working for you?  I am astounded then.  The spell check was working in 
the previous 4.1 version of imp no problem...  It does not render an 
error it simply sits at checking and does nothing....  Not sure what 
else to say.  I guess there is nothing for you to fix then.
2007-08-21 00:24:37 Michael Slusarz Comment #5 Reply to this comment
What is there to fix?  It works fine here.  Someone will have to 
provide an error message or a way to track this down, but it is 
impossible to "fix" when it isn't broken (for me at least).
2007-08-19 16:49:30 dimante (at) dimante (dot) net Comment #4 Reply to this comment
Will this be able to be fixed?
2007-08-14 19:42:23 dimante (at) dimante (dot) net Comment #3 Reply to this comment
Can almost guarantee that your aspell is not > version 0.6.0.
Glad you said almost:



aspell-0.60.5_2     Spelling checker with better suggestion logic than ispell



Does not work in this version either had 0.60 too and it did not work 
there. This worked perfectly in the prior version of IMP I really 
don't understand what changed.  The only way to get aspell to work is 
in text composition mode 8(


2007-08-14 19:16:09 Michael Slusarz Comment #2
State ⇒ Feedback
Reply to this comment
Can almost guarantee that your aspell is not > version 0.6.0.
2007-08-13 21:47:27 dimante (at) dimante (dot) net Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Summary ⇒ aspell + html composition == no spell check
Queue ⇒ IMP
Reply to this comment
I saw the ticket for PSpell but actually no spell checking is working 
with the HTML composition window.  It did in IMP 4.1.2.  What happened 
between that revision and this one...  Was working perfectly 8(

Saved Queries