Tickets :: [#5578] Turba contact lists could lose entries when switching share support on or off

6.0.0-alpha14

6/19/25

Summary	Turba contact lists could lose entries when switching share support on or off
Queue	Turba
Queue Version	HEAD
Type	Bug
State	Resolved
Priority	1. Low
Owners	mrubinsk (at) horde (dot) org
Requester	mrubinsk (at) horde (dot) org
Created	07/24/2007 (6540 days ago)
Due
Updated	08/25/2007 (6508 days ago)
Assigned	08/24/2007 (6509 days ago)
Resolved	08/25/2007 (6508 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

08/25/2007 01:35:22 PM	Michael Rubinsky	State ⇒ Resolved

08/25/2007 02:41:53 AM	Chuck Hagenbuch	Comment #4	Reply to this comment
[Show Quoted Text - 9 lines][Hide Quoted Text] I'm still torn about the first part of the issue, although I'm leaning towards saying that it is a change in sources, so we can accept those contacts disappearing from lists in other sources. While writing a maintenance task to update them would be trivial, it would either requrie a new pref to be added any time a source is switched or a hard coded check for some sort of configuration flag that would have to be checked EVERY login. Seeing how these 'foreign contacts` were not even working properly in 2.1.4 (or maybe earlier), I say just document this somewhere...thoughts? It seems okay to me to let it go.

08/24/2007 08:15:41 PM	Michael Rubinsky	Comment #3 State ⇒ Feedback	Reply to this comment
This could also happen, however, when upgrading to Turba 2.2 when the flatten shares upgrade script is run since this could also change the $cfgSource array keys as well. Fixing this in the upgrade script is not possible for all sources since we would run into authentication issues with some backends. We would have to build in some sort of maintenance in Turba to run a conversion, although I haven't looked deeply enough at this yet to know if it is 100% possible or not.... This part of the issue has been resolved with the addition of the upgradelists maintenance task. I'm still torn about the first part of the issue, although I'm leaning towards saying that it is a change in sources, so we can accept those contacts disappearing from lists in other sources. While writing a maintenance task to update them would be trivial, it would either requrie a new pref to be added any time a source is switched or a hard coded check for some sort of configuration flag that would have to be checked EVERY login. Seeing how these 'foreign contacts` were not even working properly in 2.1.4 (or maybe earlier), I say just document this somewhere...thoughts?

07/24/2007 05:05:14 PM	Michael Rubinsky	Comment #2 State ⇒ Assigned	Reply to this comment
fix state

07/24/2007 04:49:40 PM	Michael Rubinsky	Comment #1 Priority ⇒ 1. Low State ⇒ Feedback Assigned to Michael Rubinsky Queue ⇒ Turba Summary ⇒ Turba contact lists could lose entries when switching share support on or off Type ⇒ Bug	Reply to this comment
Currently, if we change the value of 'use_shares' for a given source (either turning on or off share support) any contacts contained in that source that are present in a contact list in another source would be removed from that list. This is due to the fact that the contact list uses the $cfgSource array key to signify what source the contact is from, and when we switch share support, the key changes. For this issue we could say that changing from shares to no shares (or vice versa) constitutes a change in sources so losing those contact list entries makes sense (thus turning this issue basically into a note on the UPGRADE doc). This could also happen, however, when upgrading to Turba 2.2 when the flatten shares upgrade script is run since this could also change the $cfgSource array keys as well. Fixing this in the upgrade script is not possible for all sources since we would run into authentication issues with some backends. We would have to build in some sort of maintenance in Turba to run a conversion, although I haven't looked deeply enough at this yet to know if it is 100% possible or not.... Thoughts?