6.0.0-git
2019-03-23

[#4957] Problems with handling of default shares
Summary Problems with handling of default shares
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners
Requester wrobel (at) pardus (dot) de
Created 2007-01-31 (4434 days ago)
Due
Updated 2007-02-01 (4433 days ago)
Assigned 2007-01-31 (4434 days ago)
Resolved 2007-02-01 (4433 days ago)
Milestone
Patch No

History
2007-02-01 18:53:26 Chuck Hagenbuch Comment #6
State ⇒ Resolved
Reply to this comment
Committed, thanks!
2007-02-01 17:32:51 Chuck Hagenbuch Deleted Original Message
 
2007-02-01 17:32:43 Chuck Hagenbuch Deleted Original Message
 
2007-02-01 17:32:35 Chuck Hagenbuch Deleted Original Message
 
2007-02-01 17:32:29 Chuck Hagenbuch Deleted Original Message
 
2007-02-01 17:00:35 wrobel (at) pardus (dot) de Comment #5
New Attachment: framework-Share-Share-kolab.php_Default-share-handling_20070201.patch Download
Reply to this comment
Okay. Any reason to keep the existing patches then?
No. I attached a new patch which applies only to 
framework/Share/Share/kolab.php then.



I had to fix the way internal ID/share ID/share name/default attribute 
are handled so this is a larger patch.


2007-01-31 20:12:25 Chuck Hagenbuch Comment #4
State ⇒ Stalled
Reply to this comment
Okay. Any reason to keep the existing patches then?
2007-01-31 18:42:35 wrobel (at) pardus (dot) de Comment #3 Reply to this comment
This change completely breaks backwards compatibility. Why can't the
Kolab driver support the current handling?
Ah, sorry I have to admit that I did not consider backward 
compatibility at all.



It will be possible to handle the issue without tampering with the 
nag, mnemo and kronolith side of things though this will require a 
less elegant solution on the side of the kolab driver.



The reason why it does not work at the moment is that kolab uses a 
"default" attribute on the shares while the datatree driver uses the 
unique id of the object to indicate if it is a default share or not 
(ID==username if it is a default share, random number otherwise).



I need to reconsider if I can reorganize the way the kolab driver uses 
the id so that it can convert the way horde uses the id into the 
necessary kolab attributes.
2007-01-31 17:57:55 Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
This change completely breaks backwards compatibility. Why can't the 
Kolab driver support the current handling?
2007-01-31 13:53:11   New Attachment: nag-lib-Nag.php_Default-share-handling_20070131.patch
 
2007-01-31 13:52:12   New Attachment: mnemo-lib-Mnemo.php_Default-share-handling_20070131.patch
 
2007-01-31 13:51:44   New Attachment: kronolith-lib-Kronolith.php_Default-share-handling_20070131.patch
 
2007-01-31 13:51:08 wrobel (at) pardus (dot) de Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ Problems with handling of default shares
Queue ⇒ Horde Framework Packages
New Attachment: framework-Share_Default-share-handling_20070131.patch
Reply to this comment
Default shares are handled in a different way within Kolab as compared 
to the Datatree share model.



To resolve these problems it would be good to move the default share 
handling into the Share driver rather than letting each groupware app 
handle the default share creation.



The patch adds the necessary functions for both the datatree and the 
kolab driver. I tested both variants.



The patch also fixes some problem with the handling of the "default" 
attribute within the current version of the kolab driver. The error 
handling for the kolab driver has also been improved since many of the 
IMAP errors that can be returned are rather incomprehensible.



I'll also attach the necessary patches for nag, mnemo and kronolith so 
that they use the new default share handlers.

Saved Queries