6.0.0-git
2019-09-20

[#4890] preferences: use_trash disables delhide
Summary preferences: use_trash disables delhide
Queue IMP
Queue Version Git master
Type Bug
State Not A Bug
Priority 1. Low
Owners
Requester 406728 (at) bugs (dot) debian (dot) org
Created 2007-01-14 (4632 days ago)
Due
Updated 2011-05-18 (3047 days ago)
Assigned
Resolved 2007-01-14 (4632 days ago)
Milestone
Patch No

History
2011-05-18 04:57:51 Michael Slusarz Comment #10 Reply to this comment
1) Provide an option that allows horde to "use the trash", "hide 
deleted messages", and NOT auto expunge?
* which can lead to the issue of users never expunging, but that 
happens already w/ trash disabled and delhide enabled
I might consider this as an advanced preference if a patch was 
provided.  But only in IMP 5 - this won't be backported to IMP 4.
When trash is enabled, provide UI elements to either
2)  allow user to manually hide deleted (default always to show) and 
a button to expunge deleted messages
No.  Trash is enabled.  It is expensive to search a mailbox to 
determine if there are messages marked as deleted just to activate a 
UI element.  This should not be overhead for every mailbox viewed when 
using the trash.
3) OR just put a button back in the UI to expunge the deleted messages.
This last one is the REAL issue I have I guess.   When I have trash 
enabled there is no obvious way to expunge/purge those "marked 
deleted" messages from my mailbox via horde.
Sure there is.  Just select the message you want and click on delete.   
Adding an expunge button requires just as much effort, while 
cluttering the UI with an option a user has explicitly said they don't 
want to deal with (Trash implies no expunging is needed).
2011-05-11 12:10:10 urkle (at) outoforder (dot) cc Comment #9 Reply to this comment
OK, I see you point..

How about one of these options..

1) Provide an option that allows horde to "use the trash", "hide 
deleted messages", and NOT auto expunge?
* which can lead to the issue of users never expunging, but that 
happens already w/ trash disabled and delhide enabled

When trash is enabled, provide UI elements to either
2)  allow user to manually hide deleted (default always to show) and a 
button to expunge deleted messages
3) OR just put a button back in the UI to expunge the deleted messages.
This last one is the REAL issue I have I guess.   When I have trash 
enabled there is no obvious way to expunge/purge those "marked 
deleted" messages from my mailbox via horde.
2011-05-11 06:20:54 Michael Slusarz Comment #8
Version ⇒ Git master
Reply to this comment
I too am having this issue..  The issue being using several "other" 
applications outside of horde do not follow the "horde" philosophy 
of immediately purging the folder when moving mail into the trash.   
Thus when telling horde to use the "trash" I see a cluttering of 
"deleted" messages in the horde inbox.

Mail client I use (outside of horde) on a regular basis..
No.  It is a *terrible* idea to assume that deleted flags that exist 
in a mailbox mean that they should be moved to the trash (or, even 
worse, expunged automatically and permanently).  IMP can't guess what 
other MUAs intend when they mark messages as deleted.  Thus, the only 
safe and sane option is to show these messages as flagged deleted, but 
requiring a user to take a proactive action to indicate that yes, 
indeed, he really does want those messages permanently deleted from 
the mailbox.
2011-05-11 03:34:16 urkle (at) outoforder (dot) cc Comment #7 Reply to this comment
I too am having this issue..  The issue being using several "other" 
applications outside of horde do not follow the "horde" philosophy of 
immediately purging the folder when moving mail into the trash.  Thus 
when telling horde to use the "trash" I see a cluttering of "deleted" 
messages in the horde inbox.

Mail client I use (outside of horde) on a regular basis..

Thunderbird 3.1
Apple Mail (snow leopard version)
iPad mail client (4.3.1)
iPhone mail client (3.1.3)

So for compatibility with other client, having the ability to USE the 
trash AND hide deleted is a BIG plus. (Note that I am using Horde4/Imp5)
2007-02-10 11:30:17 lmamane (at) debian (dot) org Comment #6 Reply to this comment
I remain unvoncinced. Delete-but-not-expunged messages can be left by 
other applications than IMP. The user may wish to hide those. I see no 
point in removing that choice from the user. What is *achieved* by that?



I'm applying this patch to the version distributed by Debian:



--- orig/lib/Mailbox.php

+++ mod/lib/Mailbox.php

@@ -171,7 +171,6 @@

              $this->_delhide = !$GLOBALS['imp_search']->isVTrashFolder();

          } else {

              $this->_delhide = ($GLOBALS['prefs']->getValue('delhide') &&

-                               !$GLOBALS['prefs']->getValue('use_trash') &&

                                 ($GLOBALS['imp_search']->isSearchMbox() ||

                                 
($GLOBALS['prefs']->getValue('sortby') != SORTTHREAD)));

          }


2007-02-06 23:26:53 yann (at) pleiades (dot) fr (dot) eu (dot) org Comment #5 Reply to this comment
Hi,



I reported this bug on the debian bugtracker but in fact, I saw 
deleted messages with use_trash enabled because I opened horde/imp 
while my thunderbird was still opened, so my mailbox was not yet 
expunged by thunderbird.



So this problem would happen on very seldom cases (thunderbird crashes 
and i connect after on horde), but I still think it would be better to 
enable delhide when use_trash is enabled so that it never happens.



What is the problem with enabling delhide with use_trash ?


2007-01-20 15:25:17 Jan Schneider Comment #4 Reply to this comment
No, this doesn't happen here. The mailbox is expunged after the 
message has been moved to trash.
2007-01-19 07:01:58 lmamane (at) debian (dot) org Comment #3 Reply to this comment
But if one uses the trash folder, when a deleted message gets moved, 
it still appears deleted in the original folder, until one expunges 
it. Surely you want to avoid that.
2007-01-14 12:44:48 Jan Schneider Comment #2
State ⇒ Not A Bug
Reply to this comment
No, either you use a trash folder, or the delete flag. Never both. If 
you use the trash folder, delete messages are move there, so it 
doesn't make sense to hide deleted messages - there are none.
2007-01-14 06:56:24 406728 (at) bugs (dot) debian (dot) org Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ preferences: use_trash disables delhide
Queue ⇒ IMP
Reply to this comment
When the use_trash preference is enabled, the value of the delhide 
preference is ignored and effectively forced off. Didn't you mean on 
the contrary to force it *on* when use_trash is on?



That is, replace in lib/Mailbox.php:



             $this->_delhide = ($GLOBALS['prefs']->getValue('delhide') &&

                                !$GLOBALS['prefs']->getValue('use_trash') &&

                                ($GLOBALS['imp_search']->isSearchMbox() ||

                                ($GLOBALS['prefs']->getValue('sortby') 
!= SORTTHREAD)));



by



             $this->_delhide = (($GLOBALS['prefs']->getValue('delhide') ||

                                !$GLOBALS['prefs']->getValue('use_trash')) &&

                                ($GLOBALS['imp_search']->isSearchMbox() ||

                                ($GLOBALS['prefs']->getValue('sortby') 
!= SORTTHREAD)));




Saved Queries