6.0.0-git
2019-03-20

[#4703] response message - partial bad coding
Summary response message - partial bad coding
Queue Horde Framework Packages
Queue Version HEAD
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org, slusarz (at) horde (dot) org
Requester yvon.lafaille (at) limousin (dot) iufm (dot) fr
Created 2006-11-28 (4495 days ago)
Due 11/28/2006 (4495 days ago)
Updated 2006-12-22 (4471 days ago)
Assigned 2006-11-29 (4494 days ago)
Resolved 2006-12-22 (4471 days ago)
Milestone
Patch No

History
2006-12-22 16:11:55 Jan Schneider Comment #14
Version ⇒ HEAD
Queue ⇒ Horde Framework Packages
State ⇒ Resolved
Reply to this comment
This turned out to be a bug in Horde_Prefs, not IMP. Fixed in Horde 
HEAD and 3.1.4.
2006-12-05 10:49:39 Jan Schneider Comment #13 Reply to this comment

[Show Quoted Text - 9 lines]
Of course there is. The preference value is converted from browser 
charset to backend charset when saving the pref and vice versa when 
loading the pref. The text should always be encoded in   
NLS::getCharset().
2006-12-05 08:14:16 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #12 Reply to this comment
Fixed.
I applied the fix of Jan Schneider (11/28/2006) to my test 
installation (imp-4.1.5 stable)

replacing

"$msg = $this->_expandAttribution($prefs->getValue('attrib_text'), 
$from, $h) . "\n\n" . $msg;"

with

"$msg = 
$this->_expandAttribution(String::convertCharset($prefs->getValue('attrib_text'),NLS::getCharset(), $old_part->getCharset()), $from, $h) . "\n\n" . 
$msg;"

line 355 in ./imp/lib/Compose.php



Even after applying this fix, the bug is still remaining in some case 
in the stable version (imp-4.1.3).

My default charset is "iso-8859-1".

When I am replying to a message written in charset  "iso-8859-1", it 
is correct :

"a écrit :"

But when I am replying to a message written in charset "utf8", I still 
see the bug :

"a écrit :"
2006-12-05 00:16:41 Michael Slusarz Comment #11 Reply to this comment
This still needs to be done in HEAD. I looked at it, but the place to
get the old part's charset is moved around in HEAD, and I'm not clear
I think what needs to be done is to save the browser charset at the 
time we save 'attrib_text' so we know how to convert the text when 
creating the message (i.e. via a 'attrib_text_charset' implicit pref 
set in a prefs callback).  As of right now, there is no way of knowing 
what charset 'attrib_text' is when we try to convert (definitely no 
guarantee NLS::getCharset() is the correct charset).
2006-11-29 21:48:47 Chuck Hagenbuch Comment #10
Assigned to Jan Schneider
Assigned to Michael Slusarz
State ⇒ Assigned
Reply to this comment
This still needs to be done in HEAD. I looked at it, but the place to 
get the old part's charset is moved around in HEAD, and I'm not clear 
why we're converting to the old part's charset instead of to the 
current charset anyway. Jan or Michael?
2006-11-29 15:27:09 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #9 Reply to this comment
Fixed.
It has been fixed in imp/lib/Compose.php version 1.107.2.39 (FRAMEWORK_3)



I think if remains in Imp H3 4.2-cvs.

      imp/lib/Compose.php version 1.268



I tested with Horde-3.1.3 , imp H3 4.2-cvs
2006-11-29 15:13:39 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #8 Reply to this comment
Fixed.
2006-11-28 15:18:39 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #7 Reply to this comment
Fixed.
Thank you.

But I don't know what to do to fix my own installation (which file to 
patch ?).

We are currently using "imp3" in production and I can wait for the 
next  "imp" stable version.

Today, I sent  a comment  on ticket  #3676 and I see that you 
reassigned it . I think that I don't have to open an other ticket for 
that.

I am having at time a lot of  difficulty  using "horde_share"  to 
convert a public sql address book , I will post to the turba mailing 
list.

Regards




2006-11-28 14:34:03 Jan Schneider Comment #6
State ⇒ Resolved
Reply to this comment
Fixed.
2006-11-28 13:39:06 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #5 Reply to this comment
Is this the only place where you see UTF-8 chars in translated strings?
I notice no other place  where  I see UTF-8 chars in translated strings.
2006-11-28 13:22:28 Jan Schneider Comment #4 Reply to this comment
Is this the only place where you see UTF-8 chars in translated strings?
2006-11-28 13:01:54 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #3 Reply to this comment
Sorry, I don't follow. Can you try to explain again in other words?
When replying to a message by clicking on "Répondre"(Reply),   A   
"Reply:Re: ..." window  is opening.

In the "Text" paragraph (box),  there is a sentence introducing the 
original post.

In English it looks like :

Quoting  "Name of the sender" <"email adress of the sender">

In  french this sentence is bad written

It is:

"Name of the sender" <"email adress of the sender">  a écrit :

but it should be :

"Name of the sender" <"email adress of the sender"> a écrit :








2006-11-28 10:10:03 Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
Sorry, I don't follow. Can you try to explain again in other words?
2006-11-28 09:07:33 yvon (dot) lafaille (at) limousin (dot) iufm (dot) fr Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Summary ⇒ response message - partial bad coding
Due ⇒ 2006-11-28
Queue ⇒ IMP
Reply to this comment
(Using "french" language and  charset "iso-8859-1")

when responding to a message, the end of the line introducing the 
original message is the coding of  'a écrit :' in "utf8"

it is written :

**** <****@****> a écrit :

if should have been written :

**** <****@****> a écrit :



Remark : the coding of : 'a écrit :' in "utf8" is ' a écrit :'

as '   ' is the  "NO-BREAK SPACE"


Saved Queries