6.0.0-git
2019-03-24

[#4477] MOTD not working after vhost changes
Summary MOTD not working after vhost changes
Queue Horde Base
Queue Version HEAD
Type Bug
State Resolved
Priority 1. Low
Owners ben (at)
Requester ben (at)
Created 2006-10-02 (4556 days ago)
Due
Updated 2006-10-03 (4555 days ago)
Assigned 2006-10-03 (4555 days ago)
Resolved 2006-10-03 (4555 days ago)
Milestone
Patch No

History
2006-10-03 14:32:50 ben Comment #8
State ⇒ Resolved
Reply to this comment
Committed.
2006-10-03 11:35:47 Jan Schneider Comment #7
Assigned to ben
State ⇒ Assigned
Reply to this comment
Perfect.
2006-10-03 05:02:53 ben Comment #6
New Attachment: Horde.php.patch Download
Reply to this comment
I thought about it a little more, and here's what I came up with.  I 
like this solution much better than my original.
2006-10-02 23:04:04 ben Comment #5 Reply to this comment
I thought of that, too.  But the problem there is that there is no 
opportunity to override the default motd.php with a vhost-specific 
motd.php, which completely negates the reason for using 
Horde::loadConfiguration() in the first place.
2006-10-02 20:10:15 Jan Schneider Comment #4 Reply to this comment
My proposed solution is to make motd.php set a variable ($motd ?),
and to echo the results of the Horde::loadConfiguration() call like
so:
I think this is not very intuitive for the admins that have to write 
the MOTD files. I'd rather suggest another parameter to 
loadConfiguration() whether output from the configuration file is 
considered an error or is allowed.
2006-10-02 17:24:16 ben Comment #3 Reply to this comment
after the ob_start()/ob_end_clean(), $errors contains all of the text 
from motd.php.
2006-10-02 10:37:38 Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
Why does it interpret it as an error?
2006-10-02 06:34:14 ben Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ MOTD not working after vhost changes
Queue ⇒ Horde Base
Reply to this comment
The MOTD defined in config/motd.php has not worked since the vhost 
changes.  The problem is that motd.php doesn't actually set a 
variable, so Horde::loadConfiguration() interprets what it gets from 
motd.php as an error.



My proposed solution is to make motd.php set a variable ($motd ?), and 
to echo the results of the Horde::loadConfiguration() call like so:



<?php echo Horde::loadConfiguration('motd.php', 'motd') ?>



If that seems reasonable to others, I will commit it.  Otherwise, we 
need to discuss an alternative.  (I miss my login screen 
customizations via motd.php)

Saved Queries