| Summary | Off-by-one error: Selecting NO for 'Save Attachments with message in sent-mail folder' and attaching PHP public key removes all but one of the attachments |
| Queue | IMP |
| Queue Version | HEAD |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | slusarz (at) horde (dot) org |
| Requester | breu (at) cfu (dot) net |
| Created | 2006-07-31 (5558 days ago) |
| Due | |
| Updated | 2010-01-12 (4297 days ago) |
| Assigned | 2008-11-09 (4726 days ago) |
| Resolved | 2008-12-08 (4697 days ago) |
| Milestone | 5 |
| Patch | No |
Fix for
Ticket #4221.Fix stripping attachments when saving to sent-mail folder when attaching
the PGP public key.
http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=77acfeb007d1047f940e02ed5b0d8d4800ed0e0f&r2=6a745eaa96a8f63c528d1b9361d5d320e670f0cd
http://git.horde.org/diff.php/imp/lib/Compose.php?rt=horde-git&r1=2bba73985835771c1d010717c198a250aadc2547&r2=6a745eaa96a8f63c528d1b9361d5d320e670f0cd
State ⇒ Resolved
State ⇒ Assigned
Version ⇒ HEAD
State ⇒ Stalled
sure I follow why the above means that, but if that's the case at
least this isn't destructive. If you confirm, please stall this for
5.0.
and then populate with subparts, these parts have no MIME IDs - i.e.
these IDs can not be dynamically assigned/determined by MIME_Part.
Unless you specifically set the MIME IDs at creation time - which we
do when rebuilding from IMAP message data for example - it is
impossible to access the individual MIME parts.
IIRC, this off-by-one issue deals with this limitation, and there is
no solution except to make BC-breaking changes to MIME_Part. So
stalling for Horde 5.
to fix without either breaking BC or having to rewrite MIME_Part in
IMP. Essentially the issue is that, when creating complex MIME_Parts
ourselves (i.e. not from pre-existing mail data), the MIME ID's are
not dynamically updated. Therefore, it is impossible to access any
MIME parts except for the outer-most container parts (i.e. parts 1,
2, 3).
I follow why the above means that, but if that's the case at least
this isn't destructive. If you confirm, please stall this for 5.0.
to fix without either breaking BC or having to rewrite MIME_Part in
IMP. Essentially the issue is that, when creating complex MIME_Parts
ourselves (i.e. not from pre-existing mail data), the MIME ID's are
not dynamically updated. Therefore, it is impossible to access any
MIME parts except for the outer-most container parts (i.e. parts 1, 2,
3).
Priority ⇒ 2. Medium
State ⇒ Assigned
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ Off-by-one error: Selecting NO for 'Save Attachments with message in sent-mail folder' and attaching PHP public key removes all but one of the attachments
Queue ⇒ IMP
Compose new message
Select 'Attach a copy of your PGP public key to your message?'
Attach a file
Select 'NO' for 'Save Attachments with message in sent-mail folder?'
Send message
The message that is stored in the sent folder will contain the
original attachment and the PGP attachment will be stripped.