6.0.0-git
2019-03-20

[#4065] Suggestions for showing mailbox size in IMP (Patch)
Summary Suggestions for showing mailbox size in IMP (Patch)
Queue IMP
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester ekg2002 (at) columbia (dot) edu
Created 2006-06-20 (4656 days ago)
Due
Updated 2006-07-20 (4626 days ago)
Assigned 2006-06-21 (4655 days ago)
Resolved 2006-07-20 (4626 days ago)
Milestone
Patch No

History
2006-07-20 19:33:22 Chuck Hagenbuch State ⇒ Resolved
 
2006-07-20 19:21:51 ekg2002 (at) columbia (dot) edu Comment #6 Reply to this comment
works for me. thanks.
2006-07-06 04:26:19 Michael Slusarz Comment #5 Reply to this comment
Try what I just committed.
2006-07-06 03:46:11 Michael Slusarz Comment #4 Reply to this comment
I personally think this makes much more sense to display on a separate 
page - like the delete confirmation page.  Showing the size next to 
the folders in the mailbox list, with this information disappearing on 
the next folders page load, is not totally intuitive given the current 
file size.  I will see if I can come up with a solution.
2006-07-03 20:16:19 ekg2002 (at) columbia (dot) edu Comment #3 Reply to this comment
There is a section of the patch that pertains to folders.js and 
essentially does the same thing as the given JS.



At least on my IMP test rig, the size goes away on the next page 
refresh. This was intentional, as I think it's overkill to have a 
"Show Size" and a "Do Not Show Size" action. In other words, I don't 
think the action should be sticky.



All that said, I'm open to change it.
2006-07-03 19:06:26 josephmalone (at) higlum (dot) com Comment #2 Reply to this comment
Is there no functionality to NOT show the mailbox size, once you've 
selected "Show Size" on  a folder, or did I just merge the patch 
incorrectly?



In addition, I had to add "else 
if(action=='mbox_size'){submitAction(action);}" to 
imp/templates/javascript/folders.js at line 12.  Again, is this a 
problem that only I had, or is it something that should be put in the 
patch?


2006-06-21 07:50:52 Jan Schneider Assigned to Michael Slusarz
State ⇒ Assigned
 
2006-06-20 23:54:11 ekg2002 (at) columbia (dot) edu Comment #1
Type ⇒ Enhancement
State ⇒ New
Priority ⇒ 1. Low
Summary ⇒ Suggestions for showing mailbox size in IMP (Patch)
Queue ⇒ IMP
New Attachment: mbox_size.diff Download
Reply to this comment
At the request of Matt Selsky, I've written a patch to IMP that gives 
a new action on the Folder tree to show the size of a mailbox. It is 
attached. I'd like to ask the community if they have any suggestions 
as to the implementation.



The main problem I see is that I'm not sure that IMAP/Tree::build() is 
the proper place to do the logic required. The problem I see is that I 
need to cache something in the $row array, only once. The patch works, 
but I'm not sure the implementation is the Horde (or the best) way.

Saved Queries