6.0.0-git
2019-03-20

[#4034] Vacation messages don't declare encoding
Summary Vacation messages don't declare encoding
Queue Ingo
Queue Version 1.0.1
Type Bug
State Resolved
Priority 2. Medium
Owners jan (at) horde (dot) org
Requester alex (at) segv (dot) de
Created 2006-06-13 (4663 days ago)
Due
Updated 2007-02-28 (4403 days ago)
Assigned 2006-06-21 (4655 days ago)
Resolved 2007-02-28 (4403 days ago)
Milestone
Patch No

History
2007-02-28 17:43:25 Jan Schneider Comment #8
Assigned to Jan Schneider
Taken from Horde DevelopersHorde Developers
State ⇒ Resolved
Reply to this comment
Implemented in CVS and Ingo 1.1.3.
2007-02-20 16:00:28 julien (dot) savoie (at) usainteanne (dot) ca Comment #7 Reply to this comment
this isn't a patch against ingo, but one against vacation-h3.  Which
still uses the vacation program from unix.
Even makes less sense then to add it to this ticket.
Alright fair enough, I misfiled it.  My bad
2007-02-20 15:59:27 Jan Schneider Comment #6 Reply to this comment
this isn't a patch against ingo, but one against vacation-h3.  Which
still uses the vacation program from unix.
Even makes less sense then to add it to this ticket.
2007-02-20 15:58:57 Jan Schneider Deleted Original Message
 
2007-02-20 14:22:13 julien (dot) savoie (at) usainteanne (dot) ca Comment #5 Reply to this comment
This patch isn't any better, it now hardcodes to iso-8859-1 and still
doesn't build a valid mime message.
That's silly... .vacation.msg's format is latin1.  As as I know you 
can't encode it any differently there.  If it's possible to embed a 
mime message into .vacation.msg let me know and I'll rewrite my patch.



this isn't a patch against ingo, but one against vacation-h3.  Which 
still uses the vacation program from unix.
2007-02-20 10:23:17 Jan Schneider Comment #4 Reply to this comment
This patch isn't any better, it now hardcodes to iso-8859-1 and still 
doesn't build a valid mime message.
2007-02-20 02:56:30 julien (dot) savoie (at) usainteanne (dot) ca Comment #3
New Attachment: forwards.diff
Reply to this comment
We should create a proper MIME message instead, using 8bit transfer
encoding is not a good idea. And your patch hardcodes utf-8, it
should use NLS::getCharset() instead.
Noticed this problem myself when updating the .vacation.msg files.   
UTF-8 site, plus latin1 requirement for a .vacation.msg... bad when 
people try to use french characters for example.



Fix is easy enough
2006-06-21 07:34:14 Jan Schneider Comment #2
Assigned to Horde DevelopersHorde Developers
State ⇒ Assigned
Reply to this comment
We should create a proper MIME message instead, using 8bit transfer 
encoding is not a good idea. And your patch hardcodes utf-8, it should 
use NLS::getCharset() instead.
2006-06-13 16:32:32 alex (at) segv (dot) de Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Summary ⇒ Vacation messages don't declare encoding
Queue ⇒ Ingo
New Attachment: vacation_encoding.patch Download
Reply to this comment
When using the procmail backend of ingo the generated formail code for 
vacation messages doesn't declare the encoding of the mail.



E.g. if you use german umlaute in the vacation mail, it is sent 
encoded in unicode but not declared as such. Some mailers like mutt 
assume the mail is encoded in ISO-8859-1 and will print garbage.



Suggested fix:

Add the headers:

   MIME-Version: 1.0

   Content-Type: text/plain; charset=utf-8

   Content-Transfer-Encoding: 8bit

To the formail code.



The attached patch does that.

Saved Queries