Summary | no domain set in From: when composing mail |
Queue | MIMP |
Queue Version | 1.0-ALPHA |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | slusarz (at) horde (dot) org |
Requester | alain (at) ait (dot) ac (dot) th |
Created | 11/28/2005 (7160 days ago) |
Due | |
Updated | 12/13/2005 (7145 days ago) |
Assigned | 12/10/2005 (7148 days ago) |
Resolved | 12/13/2005 (7145 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
This code was needed as the default parameters were potentially not
being set correctly from the information in the backends.php file.
Care to elaborate about the right way to fix this? Where were these
changes committed? in redirect.php?
New Attachment: Session.php.patch
diff attached).
In ./lib/Session.php:
- add 'maildomain' to the loop:
foreach (array('port', 'protocol', 'smtphost', 'smtpport') as $param) {
- remove the line a bit further down:
$_SESSION['mimp']['maildomain'] = $args['maildomain'];
That did it for me.
not being set. If I force it to a hardcoded value (the same value I
have set in servers.php) in redirect.php like:
$sessArray = array('server' => Util::getFormData('server'),
'realm' => Util::getFormData('realm'),
'port' => Util::getFormData('port'),
'protocol' => Util::getFormData('protocol'),
'maildomain' => Util::getFormData('maildomain'));
change last line to:
'maildomain' => 'ait.ac.th');
the problem goes away. Somehow this value isn't set to the value found
in the corresponding (and only) entry of ./config/servers.php:
$servers['topmail'] = array(
...
'maildomain' => 'ait.ac.th',
...
My conf.php has:
$conf['server']['server_list'] = 'none';
$conf['server']['change_server'] = false;
$conf['server']['change_port'] = false;
$conf['server']['change_protocol'] = false;
$conf['server']['change_folders'] = false;
and I guess that's relevant to this problem.
I still can't figure out yet where it should be set and isn't: in
./redirect.php? in ./lib/Session.php (MIMP_Session::createSession)? in
./templates/login/login.inc (just a form entry)?
I'll give this another try next week. Any input is welcome.
new mail) or what
Chuck has seen (when replying to a mail sent to a non-default identity)?
I've tried to apply your suggested change but that didn't fix my problem.
This statement appears at line
#123in my version (1.0-alpha) and not#129, by the way.* $Horde: mimp/compose.php,v 1.66 2005/10/09 17:57:10 slusarz Exp $
I really need to find some time to dig into this myself.
Taken from
that was sent to a non-default Identity, the compose window defaults
to the default identity, not the one it should (and does in IMP).
Looks like this is related.
Michael, I'm not quite following things right now (not really time),
but it looks like MIMP's compose.php expects to be passed an
'identity' form parameter, but MIMP doesn't set that in its compose
links, whereas IMP does...
In compose.php, in the function _formatAddr($addr), in switch
($actionID) the call at line 127 $_GET['identity'] = $default; does
not pick up the maildomain.
Changing this to the function call used by compose.php in imp works:
$_GET['identity'] = $identity->getMatchingIdentity($fromaddr);
Assigned to
State ⇒ Assigned
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ no domain set in From: when composing mail
Queue ⇒ MIMP
New Attachment: servers.php
State ⇒ Unconfirmed
When users select 'Compose', the From: field comes up
as "user@" (no domain).
This doesn't happen if that user has set up an explicit From: address
in his default identity (in that case the From: comes up OK).
In MIMP's server.php, 'maildomain' is set correctly (see attached server.php)
The same setting works in IMP.