Fri, 10 Apr 2026 05:21:32 +0000 https://bugs.horde.org/ticket/9822 Use the correct language on pages without autentication required Pages like login.php and signup.php. Patch attached (Trying to solve a chicken and egg problem :p) Wed, 06 Apr 2011 10:14:01 +0000 https://bugs.horde.org/ticket/9822#t63214 This is not correct. As the notes say, we are expecting prefs not to be set here. We should not be hackishly grabbing the language from the prefs file, esepcially since this does not take into effect whether the pref is locked. Wed, 06 Apr 2011 16:48:38 +0000 https://bugs.horde.org/ticket/9822#t63222 > This is not correct. As the notes say, we are expecting prefs not to > be set here. We should not be hackishly grabbing the language from > the prefs file, esepcially since this does not take into effect > whether the pref is locked. We know this is a bit hackish, but still, we thought that the language pref being set (locked or not), gives you the desired default language for the website. Wed, 06 Apr 2011 19:03:11 +0000 https://bugs.horde.org/ticket/9822#t63236 >> This is not correct. As the notes say, we are expecting prefs not to >> be set here. We should not be hackishly grabbing the language from >> the prefs file, esepcially since this does not take into effect >> whether the pref is locked. > > We know this is a bit hackish, but still, we thought that the > language pref being set (locked or not), gives you the desired > default language for the website. The default language for the website is provided by $this->nlsconfig->curr_default, not prefs->language. Thu, 07 Apr 2011 16:39:23 +0000 https://bugs.horde.org/ticket/9822#t63259 Michael, i understand that our patch is not correct, but i think this is still a valid bug. I changed the default nls language to 'pt_PT', and the login and registry page are still in English which doesn't seem to be the correct behavior, because i've defined the languages everywhere i could imagine, and still my newcomers will have its pages in English until they log in. Tue, 12 Apr 2011 09:22:45 +0000 https://bugs.horde.org/ticket/9822#t63533 > I changed the default nls language to 'pt_PT', and the login and > registry page are still in English which doesn't seem to be the > correct behavior, because i've defined the languages everywhere i > could imagine, and still my newcomers will have its pages in English > until they log in. The language is determined in Horde_Registry::preferredLang() so you might want to look there. We select languages in this order: 1. Preference (but this is NOT intended to be used pre-authentication; in fact, there should probably be a getAuth() check there) 2. Language selected on login screen. 3. Language in session (a guest user can set a language in a session) 4. Browser's list of accepted languages 5. NLS curr_default 6. Fallback to en_US if all else fails I tend to think that your users' browser is reporting that it wants English as its first option. Tue, 12 Apr 2011 16:53:09 +0000 https://bugs.horde.org/ticket/9822#t63552 Changes have been made in Git for this ticket: Bug #9822: Reinitialize language after loading prefs before authentication 1 files changed, 5 insertions(+), 0 deletions(-) http://git.horde.org/horde-git/-/commit/bb1ba8c73fc18e667d70541cc25b2b7fe868275c Tue, 12 Apr 2011 17:45:42 +0000 https://bugs.horde.org/ticket/9822#t63562 See Ticket #9437 - I was mistaken. I guess we were using prefs->language as the default language. But the patch provided here is still wrong. The correct solution, reinitializing the language after preferences have been loaded and ONLY in the pre-auth situation, has been implemented. Tue, 12 Apr 2011 17:46:36 +0000 https://bugs.horde.org/ticket/9822#t63563 Changes have been made in Git for this ticket: Bug #9822: Add package.xml entry 1 files changed, 5 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/720cd5ca6315be83839ccad827d9975adc11b7ea Tue, 12 Apr 2011 17:47:02 +0000 https://bugs.horde.org/ticket/9822#t63564