Fri, 10 Apr 2026 18:27:18 +0000 https://bugs.horde.org/ticket/9612 Onclick handler for Horde_Tree broken The commit 6f15654d breaks running arbitrary javascript when clicking on a node of the tree. The code that outputes the onclick attribute is now commented out, and a generic click handler is used in it's place. I'm guessing these changes were never finished? E.g., See Hermes' Start Stopwatch link in the Horde sidebar. It looks like a generic click handler is attached, but the actual javascript passed in to use is ignored. Tue, 01 Mar 2011 17:23:14 +0000 https://bugs.horde.org/ticket/9612#t61975 The onclick element should be completely removed. Going forward, we should not be running any javascript via HTML on* parameters. The *one* place where using embedded javascript may be acceptable is to open a popup window. But this should be done via the url parameter rather than onclick anyway. Tue, 01 Mar 2011 18:26:01 +0000 https://bugs.horde.org/ticket/9612#t61977 Changes have been made in Git for this ticket: Request #9612: Do not allow setting onclick in Horde_Tree 4 files changed, 13 insertions(+), 21 deletions(-) http://git.horde.org/horde-git/-/commit/d4da93521a36744dbb1b5f54486cc0a39edd8f1d Fri, 04 Mar 2011 18:21:39 +0000 https://bugs.horde.org/ticket/9612#t62043