Fri, 10 Apr 2026 14:48:28 +0000 https://bugs.horde.org/ticket/9600 Disabling Virtual Inbox in Preferences not working I can't disable the virtual inbox. Unchecking the virtual inbox in the preferences has no effect. I don't see any usage for the virtual inbox either. Sat, 26 Feb 2011 11:05:01 +0000 https://bugs.horde.org/ticket/9600#t61946 Changes have been made in Git for this ticket: Bug #9600: Fix disabling virtual folders http://git.horde.org/horde-git/-/commit/23fdbbab5d1dd4529405e87c7afbf68b55d046ea Fri, 04 Mar 2011 06:51:29 +0000 https://bugs.horde.org/ticket/9600#t62017 > Changes have been made in Git for this ticket: > > Bug #9600: Fix disabling virtual folders > > http://git.horde.org/horde-git/-/commit/23fdbbab5d1dd4529405e87c7afbf68b55d046ea with this commit, IMP runs indefinitely over here and never get passed the following call $injector->getInstance('IMP_Imap_Tree')->updateVFolders($vfolders); Typo ? -- if (IMP_Factory_Imaptree::initialized()) { ++ if (!IMP_Factory_Imaptree::initialized()) { Fri, 04 Mar 2011 15:16:29 +0000 https://bugs.horde.org/ticket/9600#t62031 I can confirm the issue, as well as the fact that this change fixes it. Though if this fix is correct, I don't think we even need the conditional to begin with. I admit I don't fully understand how we *don't* get infinite recursion here, but my guess is that it's because the IMP_Imap_Tree object is already cached by the injector even though IMP_Imap_Tree::init() hasn't completed, so when IMP_Search::setVFolders() is called, the IMP_Imap_Tree::updateVFolders() call succeeds? Either way, I'll leave this for Michael to fix :) Fri, 04 Mar 2011 15:55:22 +0000 https://bugs.horde.org/ticket/9600#t62032 > Typo ? > > -- if (IMP_Factory_Imaptree::initialized()) { > ++ if (!IMP_Factory_Imaptree::initialized()) { Definitely no. We only want to update the tree object *IF* it has already been created. We don't need to update if has not yet been created (virtual folders will automatically be added the first time the tree object is created). Fri, 04 Mar 2011 17:18:28 +0000 https://bugs.horde.org/ticket/9600#t62036 Changes have been made in Git for this ticket: Bug #9600: Fix determination if imaptree object has been initialized 1 files changed, 11 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/c5e1618dd1a4e2cf055d70de869c9d6fc4572f94 Fri, 04 Mar 2011 17:22:16 +0000 https://bugs.horde.org/ticket/9600#t62037 > I can confirm the issue, as well as the fact that this change fixes > it. Though if this fix is correct, I don't think we even need the > conditional to begin with. I admit I don't fully understand how we > *don't* get infinite recursion here, but my guess is that it's > because the IMP_Imap_Tree object is already cached by the injector > even though IMP_Imap_Tree::init() hasn't completed, so when > IMP_Search::setVFolders() is called, the > IMP_Imap_Tree::updateVFolders() call succeeds? The problem came with my addition of the session key check for treeob. I misread the code and thought that this key was not set until after the first session access. However, it is created before we even initialize the imaptree object the first time. This has been fixed (although strangely enough, this did not affect me). Fri, 04 Mar 2011 17:22:22 +0000 https://bugs.horde.org/ticket/9600#t62038 Changes have been made in Git for this ticket: Bug #9600: Fix variable scope 1 files changed, 4 insertions(+), 4 deletions(-) http://git.horde.org/horde-git/-/commit/1f2728072340fcc4263c0f77bc1e7e1c9ea5ced9 Fri, 04 Mar 2011 17:43:53 +0000 https://bugs.horde.org/ticket/9600#t62040