Fri, 10 Apr 2026 00:02:41 +0000 https://bugs.horde.org/ticket/9565 Imap_Client fails with literal data on setMetadata command When using the setMetadata() method and trying to set the /comment value to "Ä" the generated IMAP output is incorrect: C: 2 SETANNOTATION INBOX ("/comment" ("value.shared" {2+} C: Ä C: )) S: 2 BAD Missing close paren in annotation attribute-values list Working output would be: DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} DEBUG: C: Ä) DEBUG: S: A0002 OK Completed I currently lacked the time to further investigate this but I can do so at a later time.Unless of course it is something totally trivial for Micheal :) Sat, 05 Feb 2011 22:27:15 +0000 https://bugs.horde.org/ticket/9565#t61730 > Working output would be: > > DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} > DEBUG: C: Ä) > DEBUG: S: A0002 OK Completed This is incorrect also. This should be: DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} DEBUG: C: Ä DEBUG: C: ) DEBUG: S: A0002 OK Completed The ')' is part of the IMAP command, not the literal, so it needs to appear on a new line. This has been fixed (I think; don't have an easy way to test at the moment): http://lists.horde.org/archives/commits/2011-February/006677.html It also looked like the 'SETMETADATA' method was also broken - this should be fixed also. Tue, 08 Feb 2011 16:59:14 +0000 https://bugs.horde.org/ticket/9565#t61733 >> Working output would be: >> >> DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} >> DEBUG: C: Ä) >> DEBUG: S: A0002 OK Completed > > This is incorrect also. This should be: > > DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} > DEBUG: C: Ä > DEBUG: C: ) > DEBUG: S: A0002 OK Completed > > The ')' is part of the IMAP command, not the literal, so it needs to > appear on a new line. Ah, okay. The above command I posted was generated by the roundcube IMAP driver and I just copied it. The server apparently did not care about the misplaced parenthesis. > > This has been fixed (I think; don't have an easy way to test at the moment): It fails with (1297208022.0143) C: 2 SETANNOTATION (1297208022.1472) S: 2 BAD Missing required argument to Setannotation now. Testing is easy on my side as this just requires a short command line call. If you need more info just tell me. Thanks for investigating this! > http://lists.horde.org/archives/commits/2011-February/006677.html > > It also looked like the 'SETMETADATA' method was also broken - this > should be fixed also. Tue, 08 Feb 2011 23:39:26 +0000 https://bugs.horde.org/ticket/9565#t61734 >>> Working output would be: >>> >>> DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} >>> DEBUG: C: Ä) >>> DEBUG: S: A0002 OK Completed >> >> This is incorrect also. This should be: >> >> DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} >> DEBUG: C: Ä >> DEBUG: C: ) >> DEBUG: S: A0002 OK Completed Hm, looks like that after your last commit now. The server is still unhappy though: (1297234921.0173) C: 2 SETANNOTATION INBOX "/comment" ("value.shared" {2+} (1297234921.0177) C: Ä (1297234921.0180) C: ) (1297234921.3045) S: 2 BAD Missing close paren in annotation attribute-values list >> >> The ')' is part of the IMAP command, not the literal, so it needs to >> appear on a new line. > > Ah, okay. The above command I posted was generated by the roundcube > IMAP driver and I just copied it. The server apparently did not care > about the misplaced parenthesis. > >> >> This has been fixed (I think; don't have an easy way to test at the moment): > > It fails with > > (1297208022.0143) C: 2 SETANNOTATION > (1297208022.1472) S: 2 BAD Missing required argument to Setannotation > > now. Testing is easy on my side as this just requires a short command > line call. If you need more info just tell me. Thanks for > investigating this! > >> http://lists.horde.org/archives/commits/2011-February/006677.html >> >> It also looked like the 'SETMETADATA' method was also broken - this >> should be fixed also. > Wed, 09 Feb 2011 07:05:09 +0000 https://bugs.horde.org/ticket/9565#t61736 Changes have been made in Git for this ticket: Bug #9565: Never send CRLF after literal http://git.horde.org/horde-git/-/commit/0ee34548ff77cfabdb68bdb5c88832072e97bb05 Wed, 09 Feb 2011 17:52:24 +0000 https://bugs.horde.org/ticket/9565#t61739 This is correct. Forgot that the 8-bit character counts as 2 octets: >>>> DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} >>>> DEBUG: C: Ä) >>>> DEBUG: S: A0002 OK Completed This is incorrect: >>> DEBUG: C: A0002 SETANNOTATION INBOX "/comment" ("value.shared" {2+} >>> DEBUG: C: Ä >>> DEBUG: C: ) >>> DEBUG: S: A0002 OK Completed The IMAP client code was properly outputting literal data when that data was being stored internally in a stream. However, when the literal data was stored internally in a string, we were tacking on a CRLF after the literal data. This was terminating the command early. This should be fixed (for real this time). Wed, 09 Feb 2011 17:54:36 +0000 https://bugs.horde.org/ticket/9565#t61740 Changes have been made in Git for this ticket: Bug #9565: Need to send CRLF after literalplus request http://git.horde.org/horde-git/-/commit/67ab4d8fe94d3387d9d7f708a6735ebecfedcbaa Wed, 09 Feb 2011 18:15:49 +0000 https://bugs.horde.org/ticket/9565#t61743 > This should be fixed (for real this time). Confirmed :) Thanks a lot! Wed, 09 Feb 2011 20:05:08 +0000 https://bugs.horde.org/ticket/9565#t61749