Sender validation fails for non-ascii letters

Not quite certain if the problem is caused by non-ascii lett

Wed, 19 Jan 2011 13:24:34 +0000

Not quite certain if the problem is caused by non-ascii letters in general but when trying to send a message to ß in the dynamic version of imp I get the error that sending of the message failed with Validation failed for: ß

I don't see this. Just sent a message and it worked fine.

Wed, 19 Jan 2011 19:14:24 +0000

I don't see this. Just sent a message and it worked fine. Headers: [...] To: =?utf-8?b?w58=?= Subject: Test User-Agent: Internet Messaging Program (IMP) H4 (5.0-git) [...]

The following test for the "Mail" package reproduces the pro

Wed, 19 Jan 2011 21:05:42 +0000

The following test for the "Mail" package reproduces the problem on my side: diff --git a/framework/Mail/test/Horde/Mail/ParseTest.php b/framework/Mail/test/Horde/Mail/ParseTest.php index f095c1c..fec8988 100644 --- a/framework/Mail/test/Horde/Mail/ParseTest.php +++ b/framework/Mail/test/Horde/Mail/ParseTest.php @@ -189,4 +189,16 @@ class Horde_Mail_ParseTest extends PHPUnit_Framework_TestCase $this->assertEquals(count($res), 3); } + public function testBug9525() + { + $parser = new Horde_Mail_Rfc822(); + $ob = $parser->parseAddressList( + 'ß ', + array( + 'default_domain' => 'pardus.de', + 'nest_groups' => false, + 'validate' => true + ) + ); + } } Having a unit test now I assume I would be able to solve it myself. I just wont find the time today anymore and in case you immediately spot the problem I'm of course happy if I don't have to dive into the code :)

Changes have been made in Git for this ticket: Bug #9525: A

Thu, 20 Jan 2011 04:12:00 +0000

Changes have been made in Git for this ticket: Bug #9525: Add validation tests http://git.horde.org/horde-git/-/commit/d17e468f3b8c781100fad3bfadb305fdd4164b5d

> + 'ß ', Except this is

Thu, 20 Jan 2011 04:14:32 +0000

> + 'ß ', Except this *is* an invalid address. The ß must be quoted - if it is, the validation correctly passes. So for whatever reason this character is being quoted when I send a message but not when you send a message. We need to find where in IMP this quoting is failing to occur (unit tests are unfortunately not going to help us here :( ).

Ah, I see. Thanks for the feedback. The validation fails

Thu, 20 Jan 2011 05:59:55 +0000

Ah, I see. Thanks for the feedback. The validation fails on l.850 in imp/lib/Compose.php. Is the Horde_Mime::encodeAddress call above it the one that should quote it?

Changes have been made in Git for this ticket: Bug #9525: A

Thu, 20 Jan 2011 06:21:22 +0000

Changes have been made in Git for this ticket: Bug #9525: Add Horde_Mime::encodeAddress() tests http://git.horde.org/horde-git/-/commit/8696a5446ebb64c22233e6ec37f6379ae42eb98c

> The validation fails on l.850 in imp/lib/Compose.php. Is t

Thu, 20 Jan 2011 06:22:26 +0000

> The validation fails on l.850 in imp/lib/Compose.php. Is the > Horde_Mime::encodeAddress call above it the one that should quote it? Yes. The email address should be MIME encoded after that call, so it will pass validation (since it no longer contains non-7bit characters). Added some tests to horde/Mime - both pass for me.

In both tests you use 'UTF-8' as charset. In my case $messag

Thu, 20 Jan 2011 06:51:31 +0000

In both tests you use 'UTF-8' as charset. In my case $message->getHeaderCharset() returns 'us-ascii' which is probably causing the problems. I'm replying to another message. Might that result in assuming an incorrect character set here?

Changes have been made in Git for this ticket: Bug #9525: S

Thu, 20 Jan 2011 07:20:08 +0000

Changes have been made in Git for this ticket: Bug #9525: Switch header charsets if we can't encode properly http://git.horde.org/horde-git/-/commit/0c59c79c42530ea086a137b065da74d6292704f7

This should fix things (?)

Thu, 20 Jan 2011 07:20:21 +0000

This should fix things (?)

It does. Thanks for the quick fix!

Thu, 20 Jan 2011 07:50:00 +0000

It does. Thanks for the quick fix!