includeStylesheetFiles() cannot be called multiple times

I'm not sure whether we want to change the includeStylesheet

Wed, 03 Nov 2010 13:47:59 +0000

I'm not sure whether we want to change the includeStylesheetFiles() behavior, or change the stylesheet loading in the SyntaxHighlighter Mime_Viewer. But atm the mime viewer calls Horde_Themes::includeStylesheetFiles() which: 1) adds tags inline, which is invalid, though obviously supported by all browsers. 2) loads all default stylesheets again.

Haven't had a chance to look at this in detail, but includeS

Thu, 04 Nov 2010 17:22:12 +0000

Haven't had a chance to look at this in detail, but includeStylesheetFiles() should not be called inside of a Mime Viewer. includeStylesheetFiles() needs to be called by the script generating the output only (e.g. imp/view.php). If there is not a way to do this (queuing stylesheet files), this should be added to Horde_Themes.

IIRC the problem was that the page header was already sent w

Thu, 04 Nov 2010 17:29:06 +0000

IIRC the problem was that the page header was already sent when the mime viewer code was triggered. But Chuck knows better.

Yeah. We probably in general want output buffering on for th

Fri, 05 Nov 2010 03:27:20 +0000

Yeah. We probably in general want output buffering on for the page so that we can add headers, stylesheets, etc. from anywhere easily.

Changes have been made in Git for this ticket: Bug #9358: A

Tue, 09 Nov 2010 08:15:28 +0000

Changes have been made in Git for this ticket: Bug #9358: Add Horde_Themes::addStylesheetFile() http://git.horde.org/diff.php/ansel/lib/Ansel.php?rt=horde-git&r1=6287faff03e67682802dc866ed46177dcac31472&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/framework/Core/lib/Horde/Core/Mime/Viewer/Syntaxhighlighter.php?rt=horde-git&r1=99427b115951b059c83f71c48f5b439cd9af1685&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/framework/Core/lib/Horde/Themes.php?rt=horde-git&r1=8352173fc37d37ad4a99af2a4508a8b7e9600f50&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/horde/services/portal/index.php?rt=horde-git&r1=ec604b28b431054f96ce346520e8b98de031102a&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/horde/templates/common-header.inc?rt=horde-git&r1=e60da622060274282dd92c2d41c4c0dce4724dd6&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/imp/templates/common-header.inc?rt=horde-git&r1=e60da622060274282dd92c2d41c4c0dce4724dd6&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/jonah/lib/View/StoryView.php?rt=horde-git&r1=1deb6ef576189be20dc9214dd67e681c4691c4c0&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/mnemo/templates/common-header.inc?rt=horde-git&r1=e60da622060274282dd92c2d41c4c0dce4724dd6&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/nag/templates/common-header.inc?rt=horde-git&r1=e60da622060274282dd92c2d41c4c0dce4724dd6&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694 http://git.horde.org/diff.php/trean/templates/common-header.inc?rt=horde-git&r1=e60da622060274282dd92c2d41c4c0dce4724dd6&r2=93b9dd4ab70feb68b2c2fcfa9c4a1a4831063694

Added Horde_Themes::addStylesheetFile() to queue additional

Tue, 09 Nov 2010 08:18:00 +0000

Added Horde_Themes::addStylesheetFile() to queue additional stylesheet files to be added on top of the base application CSS files. As previously mentioned, Horde_Themes::includeStylesheetFiles() is designed to be called once only per page access - most often in [app]/templates/common-header.inc.