Fri, 10 Apr 2026 15:00:33 +0000 https://bugs.horde.org/ticket/9219 display_tasklists is saved on every page access The code in Nag#initialize() saves the value of display_tasklists every time it is run. Should be refactored to only save if tasklist changes. Noticed this in my logs when doing a dimp poll refresh - for some reason, display_tasklists was being updated. Not familiar with the code but making the assumption that display_tasklists doesn't change on a regular basis. (If it does, it should not be a preference at all). Fri, 03 Sep 2010 17:44:45 +0000 https://bugs.horde.org/ticket/9219#t59825 This happens in other applications, for example Kronolith, all the time. But the prefs library is only saving it when the preference value changed. Are you saying this check doesn't work anymore, or is the preference value really changed? Tue, 21 Sep 2010 16:16:01 +0000 https://bugs.horde.org/ticket/9219#t60087 Seeing this all over the place: 2010-09-22T00:39:08-06:00 DEBUG: HORDE [nag] Horde_Prefs: Storing preference value (display_tasklists) [pid 30516 on line 257 of "/disk2/src/horde/framework/Prefs/lib/Horde/Prefs.php"] As someone who never uses nag, I have no idea why this needs/should be updated every page load. Even if the value isn't changing, we shouldn't be wasting time recreating at all. At a minimum, this really needs to be cached (see, e.g., caching IMP's folder tree using session caching as a fallback if no Cache system is available). Wed, 22 Sep 2010 06:45:33 +0000 https://bugs.horde.org/ticket/9219#t60106 > Seeing this all over the place: > > 2010-09-22T00:39:08-06:00 DEBUG: HORDE [nag] Horde_Prefs: Storing > preference value (display_tasklists) [pid 30516 on line 257 of > "/disk2/src/horde/framework/Prefs/lib/Horde/Prefs.php"] Move it further down into the if-clause where the saving is actually triggered. :) > As someone who never uses nag, I have no idea why this needs/should > be updated every page load. Even if the value isn't changing, we > shouldn't be wasting time recreating at all. At a minimum, this > really needs to be cached (see, e.g., caching IMP's folder tree using > session caching as a fallback if no Cache system is available). It's almost a no-op, so I wouldn't really care about that. And you probably see this because of the Copy/Move to Tasklist feature. Wed, 22 Sep 2010 23:54:37 +0000 https://bugs.horde.org/ticket/9219#t60128 Changes have been made in Git for this ticket: Request #9219: Move pref saving logging to a more appropriate location http://git.horde.org/diff.php/framework/Prefs/lib/Horde/Prefs.php?rt=horde-git&r1=77e3dd782f525dadbb88512854d903ac2d7f9cb9&r2=b4a73fd1a465e79c3be80e12e225f7cc6c268dcd Thu, 23 Sep 2010 19:06:31 +0000 https://bugs.horde.org/ticket/9219#t60142 >> Seeing this all over the place: >> >> 2010-09-22T00:39:08-06:00 DEBUG: HORDE [nag] Horde_Prefs: Storing >> preference value (display_tasklists) [pid 30516 on line 257 of >> "/disk2/src/horde/framework/Prefs/lib/Horde/Prefs.php"] > > Move it further down into the if-clause where the saving is actually > triggered. :) Done. >> As someone who never uses nag, I have no idea why this needs/should >> be updated every page load. Even if the value isn't changing, we >> shouldn't be wasting time recreating at all. At a minimum, this >> really needs to be cached (see, e.g., caching IMP's folder tree using >> session caching as a fallback if no Cache system is available). > > It's almost a no-op, so I wouldn't really care about that. And you > probably see this because of the Copy/Move to Tasklist feature. OK. I'll close this ticket. Thu, 23 Sep 2010 19:07:51 +0000 https://bugs.horde.org/ticket/9219#t60143