Thu, 09 Apr 2026 16:55:01 +0000 https://bugs.horde.org/ticket/8973 Hermes to ignore completed nag tasks. I'm trying to get hermes to ignore completed tasks in nag. Hermes, does in fact make a request for incomplete tasks via hermes/lib/Forms/Time.php: $criteria = array('user' => Auth::getAuth(), 'active' => true) However in the nag/lib/api.php, the list tasks, ignores the criteria (per the code comment) Making the following changes appear to work: while ($task = $tasks->each()) { if ($criteria['active'] == $task->completed) continue; However, I have no idea what side effects I just introduced. :( Monty ====== nag/api.php====== /** * Lists active tasks as cost objects. * * @todo Implement $criteria parameter. * * @param array $criteria Filter attributes */ function _nag_listCostObjects($criteria) { require_once dirname(__FILE__) . '/base.php'; $tasks = Nag::listTasks(null, null, null, null, 1); $result = array(); $tasks->reset(); while ($task = $tasks->each()) { $result[$task->id] = array('id' => $task->id, 'active' => !$task->completed, 'name' => $task->name); if (!empty($task->estimate)) { $result[$task->id]['estimate'] = $task->estimate; } } if (count($result) == 0) { return array(); } else { return array(array('category' => _("Tasks"), 'objects' => array_values($result))); } } Sat, 17 Apr 2010 23:06:09 +0000 https://bugs.horde.org/ticket/8973#t58552 It's the expected behavior, Hermes should show all tasks, not only completed. Sun, 18 Apr 2010 12:15:22 +0000 https://bugs.horde.org/ticket/8973#t58553 In the code comment, it said implementing $criteria was a "todo item". It doesn't seem like current behavior is what is ultimately wanted. Otherwise calling functions would be passing null criteria - or just strip out the arg altogether. 50-60 tasks in a drop down box is extremely annoying. I think I will stick with my fix. > It's the expected behavior, Hermes should show all tasks, not only completed. Sun, 18 Apr 2010 14:31:43 +0000 https://bugs.horde.org/ticket/8973#t58559 > It's the expected behavior, Hermes should show all tasks, not only completed. This is different, however, from Whups' behavior. In Hermes, only tickets in one of the "open" states are shown. This has its own practical problems because 1) you can't track time to closed tickets and 2) When reviewing time on closed tickets the UI shows strange things. However I agree with the reporter that having such a large drop-down is unmanageable. I think we need to find a third solution. Thu, 27 May 2010 20:26:17 +0000 https://bugs.horde.org/ticket/8973#t58981 Agreed, both that we need to handle this consistently, and that we need a better way to deal with cost objects. That should be separate request though. Thu, 27 May 2010 20:41:38 +0000 https://bugs.horde.org/ticket/8973#t58982