Horde::logMessage calls Horde_Log_Logger::log bad values

Trying to install Horde4 from current GIT kept giving me "Ba

Sat, 27 Mar 2010 00:44:48 +0000

Trying to install Horde4 from current GIT kept giving me "Bad log level" error pages until I tracked down the problem in the Horde class in "framework/Core/lib/Horde.php" where the logMessage method was passing Horde_Log_Logger::log a $priority string instead of the integer $level it expected.

Changes have been made in Git for this ticket: Bug #8937: C

Sat, 27 Mar 2010 01:54:16 +0000

Changes have been made in Git for this ticket: Bug #8937: Convert priority to integer; don't exit prematurely http://git.horde.org/diff.php/framework/Core/lib/Horde/Core/Log/Logger.php?rt=horde-git&r1=b24b186ef95eec69c770bf491edef85fcb12c5f0&r2=a4a808da9446fd1d5ef4a35095df6e045794aaf8

No - it is perfectly acceptable to pass a string to the logg

Sat, 27 Mar 2010 01:55:36 +0000

No - it is perfectly acceptable to pass a string to the logger. Horde_Core_Log_Logger should do the conversion. However, there was a certain case where this conversion wasn't happening and that has been fix. Additionally, this same case was exiting the entire script, which wasn't necessary. See if these changes fix things for you.

> No - it is perfectly acceptable to pass a string to the lo

Sat, 27 Mar 2010 02:06:56 +0000

> No - it is perfectly acceptable to pass a string to the logger. > Horde_Core_Log_Logger should do the conversion. However, there was a > certain case where this conversion wasn't happening and that has been > fix. Additionally, this same case was exiting the entire script, > which wasn't necessary. Well, Horde::logMessage calls Horde_Log_Logger::log not Horde_Core_Log_Logger::log, despite the comment's reference to the latter. Horde_Core_Log_Logger extends Horde_Log_Logger, changing the behavior of the log method. I'm not sure exactly how this should be fixed, but the inconsistency between those two log methods seems unnecessarily confusing.

> Well, Horde::logMessage calls Horde_Log_Logger::log not

Mon, 29 Mar 2010 20:53:32 +0000

> Well, Horde::logMessage calls Horde_Log_Logger::log not > Horde_Core_Log_Logger::log, despite the comment's reference to the > latter. This is incorrect. Horde::logMessage() calls the injector and asks for the instance bound to 'Horde_Log_Logger'. This binder (Horde_Core_Binder_Logger) returns a Horde_Core_Log_Logger instance (see Core/lib/Horde/Core/Binder/Logger.php). The injector pattern is necessary to ensure that the Horde_Log package is not dependent on any given Horde installation - in other words, Horde_Log can be used independently of Horde the application. Horde_Log requires an integer input for log() - mainly because this maps with other logger API interfaces. However, using Horde_Log integer logging constants is troubling in Horde since the log level is defined in a configuration file, which may be loaded before Horde_Log itself is available. Thus, the need to allow strings to be used for log levels within Horde.

OK, thanks;
Tue, 30 Mar 2010 06:30:46 +0000
OK, thanks; does seem to fix it for me.