Sieve filter updates to features

Ive had to update my Lib/Script/sieve.php so that it correct

Thu, 17 Dec 2009 16:24:24 +0000

Ive had to update my Lib/Script/sieve.php so that it correctly applied imap4flags instead of imapflags. This should mabey be a toggle option depending on what version of software people are using. Taken from http://wiki.dovecot.org/LDA/Sieve Note that the CMU Sieve plugin implements an older specification of the enotify extension which was called notify. Something similar is true for the imap4flags extension, which was known as imapflags for CMU Sieve. For backwards compatibility, Dovecot Sieve plugin also supports the old imapflags extension. The most valuable extension that the new Sieve implementation adds to the list is the variables extension. As the name implies, this adds support for variables to the language.

Why? The quote that you pasted explicitly says that the imap

Fri, 18 Dec 2009 12:30:26 +0000

Why? The quote that you pasted explicitly says that the imapflags extension is supported for backward compatibility.

> Why? The quote that you pasted explicitly says that the im

Fri, 18 Dec 2009 15:07:59 +0000

> Why? The quote that you pasted explicitly says that the imapflags > extension is supported for backward compatibility. This is an old standard, it may not be fully supported in the future. This is a heads up to mabey consider it as a toggle for servers that do/dont support for if/when its removed. http://tools.ietf.org/html/rfc5232

+1 for this to be finally changed in Horde 4

Tue, 05 Jul 2011 17:16:54 +0000

+1 for this to be finally changed in Horde 4

This should be per-driver level. Because at least Cyrus does

Mon, 17 Oct 2011 13:58:48 +0000

This should be per-driver level. Because at least Cyrus doesn't support imap4flags as far as I know.

For those having issues with notify => enotify here's a simp

Mon, 14 Apr 2014 15:22:28 +0000

For those having issues with notify => enotify here's a simple fix: > --- Notify.old.php 2013-08-29 15:18:38.040018368 +0200 > +++ horde/ingo/lib/Script/Sieve/Action/Notify.php 2014-04-14 17:03:18.347365694 +0200 > @@ -45,13 +45,7 @@ > */ > public function generate() > { > - return 'notify :method "mailto" :options "' . > - Ingo_Script_Sieve::escapeString($this->_vars['address']) . > - '" :message "' . > - _("You have received a new message") . "\n" . > - _("From:") . " \$from\$ \n" . > - _("Subject:") . " \$subject\$ \n" . > - _("Rule:") . ' ' . $this->_vars['name'] . '";'; > + return 'notify "mailto:' . Ingo_Script_Sieve::escapeString($this->_vars['address']) . '";'; > } > > /** > @@ -75,6 +69,6 @@ > */ > public function requires() > { > - return array('notify'); > + return array('enotify'); > } > }

Changes have been made in Git (master): commit 199448a47e4b

Mon, 14 Apr 2014 23:50:13 +0000

Changes have been made in Git (master): commit 199448a47e4be0f41a3c36db006a59d92ec8e872 Author: Michael M Slusarz Date: Mon Apr 14 17:28:51 2014 -0600 [mms] Use standardized 'imap4flags' sieve extension (RFC 5232) by default instead of deprecated 'imapflags' extension (Request #8784). ingo/config/backends.php | 5 ++ ingo/docs/CHANGES | 2 + ingo/docs/UPGRADING | 8 ++++ ingo/lib/Script/Sieve.php | 57 ++++++++++++++++++++----- ingo/lib/Script/Sieve/Action/Flag.php | 72 +++++++++++++++++---------------- ingo/package.xml | 1 + ingo/test/Ingo/Unit/SieveTest.php | 2 +- 7 files changed, 99 insertions(+), 48 deletions(-) http://github.com/horde/horde/commit/199448a47e4be0f41a3c36db006a59d92ec8e872

Changes have been made in Git (master): commit f02779988d2e

Mon, 14 Apr 2014 23:50:19 +0000

Changes have been made in Git (master): commit f02779988d2e0bae25286b62f0440071389837c2 Author: Michael M Slusarz Date: Mon Apr 14 17:49:34 2014 -0600 [mms] Use standardized 'enotify' sieve extension (RFC 5435) by default instead of deprecated 'notify' extension (Request #8784). ingo/config/backends.php | 4 ++++ ingo/docs/CHANGES | 2 ++ ingo/docs/UPGRADING | 8 ++++++-- ingo/lib/Script/Sieve.php | 6 +++++- ingo/lib/Script/Sieve/Action/Notify.php | 26 +++++++++++++++++++------- ingo/package.xml | 1 + 6 files changed, 37 insertions(+), 10 deletions(-) http://github.com/horde/horde/commit/f02779988d2e0bae25286b62f0440071389837c2

Ingo 3.2.0

Mon, 14 Apr 2014 23:50:27 +0000

Ingo 3.2.0

Thanks for the quick fixes Michael, however the enotify fix

Tue, 15 Apr 2014 00:03:45 +0000

Thanks for the quick fixes Michael, however the enotify fix won't work. In particular the variables in the :message-tag won't work that way. You can find examples with working subject/from variables in the RFC section 3.7: https://tools.ietf.org/html/rfc5435#page-6 (example 1) Also note that the RFC recommends to include the from + subject headers by default (section 3.6). That's why my patch just removes it. Afaik Dovecot just includes the subject.

Changes have been made in Git (master): commit 770646adad05

Tue, 15 Apr 2014 07:17:24 +0000

Changes have been made in Git (master): commit 770646adad052fe56f0fce8c8836abfc41c96c94 Author: Michael M Slusarz Date: Mon Apr 14 20:03:30 2014 -0600 Use server defined notification message for enotify (Request #8784) ingo/lib/Script/Sieve/Action/Notify.php | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/770646adad052fe56f0fce8c8836abfc41c96c94