Fri, 10 Apr 2026 15:26:36 +0000 https://bugs.horde.org/ticket/8757 Turba favourites driver does not provide removeUserData function Turba API function removeUserData calls removeUserData for configured contact sources. Favourites driver does not implement this function and an error is returned: Removing user data is not supported in the current address book storage driver. Attached patch implements this functionality by adding a new function to IMP API. Mon, 07 Dec 2009 16:27:29 +0000 https://bugs.horde.org/ticket/8757#t57033 I could be wrong, but I believe this data could also be used for auditing and reporting purposes, so should not be deleted. Mon, 07 Dec 2009 18:50:49 +0000 https://bugs.horde.org/ticket/8757#t57040 The information could be removed by IMP, though. Mon, 07 Dec 2009 19:47:45 +0000 https://bugs.horde.org/ticket/8757#t57043 Ah, right, it garbage collects the storage and deletes all entries before a certain time. In that case, though, I still don't think it makes sense to add this, since those entries will be gc'd as more email is sent from other users anyway... Mon, 07 Dec 2009 19:58:38 +0000 https://bugs.horde.org/ticket/8757#t57044 I agree with Michael. Mon, 07 Dec 2009 21:19:15 +0000 https://bugs.horde.org/ticket/8757#t57046 The case I have in mind is when a user is deleted from the system and a new one is created with the same username (this is not unusual in large installations with automatically generated usernames). For these cases I want to make sure all data from the old user is completely removed from the database. Leaving the favourites addressbook in the database allows the new user to see the mail recipients of the previous user. Tue, 08 Dec 2009 08:58:48 +0000 https://bugs.horde.org/ticket/8757#t57052 Okay, that's a use case that we should reconsider. But why are you overcomplicating things by adding a new API method and routing the deletion through Turba? Why don't you simply implement a removerUserData method in IMP's API? Tue, 08 Dec 2009 10:53:17 +0000 https://bugs.horde.org/ticket/8757#t57056 Yes, the problem is that favourites is implemented in IMP but accessed through Turba. Turba calls removeUserData in turba/lib/Driver/favourites.php, but since this wasn't implemented an error was returned by the default implementation in turba/lib/Driver.php. So I added removeUserData to turba/lib/Driver/favourites.php but also had to create a new api call to pass the request to IMP. Don't know if there is a cleaner way to do this, perhaps by moving favourites functionality from IMP into Turba. Tue, 08 Dec 2009 11:33:38 +0000 https://bugs.horde.org/ticket/8757#t57057 > Yes, the problem is that favourites is implemented in IMP but > accessed through Turba. Turba calls removeUserData in > turba/lib/Driver/favourites.php, but since this wasn't implemented an > error was returned by the default implementation in > turba/lib/Driver.php. So I added removeUserData to > turba/lib/Driver/favourites.php but also had to create a new api call > to pass the request to IMP. Don't know if there is a cleaner way to > do this, perhaps by moving favourites functionality from IMP into > Turba. I agree with Jan. Turba is only a consumer of the favorites data, IMP is responsible for it. You should change your patch to implement a removeUserData api inside of IMP itself. If you are concerned about getting an error message from Turba, I guess we can override the removeUserData method in favorites.php to have it simply return true, or perhaps a more accurate error message. Tue, 02 Mar 2010 14:59:52 +0000 https://bugs.horde.org/ticket/8757#t58113