Fri, 10 Apr 2026 03:14:11 +0000 https://bugs.horde.org/ticket/8595 1-click add_address from message display fails with LDAP driver The bug was noticed with the latest stable Turba (just updated to 2.3.2) & 2.4.17 OpenLDAP for address and address book storage. I noticed last week that clicking on the little "add" icon next to a new address (ie, an address not yet in my default address book) in the IMP message display gave me an error "Read failed: (0) Success" Clicking on "add" for an existing address returned the correct "Already exists" result. I found the issue to be the method, _get_results, in turba/lib/Driver/ldap.php, that checks the results of a search for a duplicate address before adding the new one . When nothing is found (ie, the results array is empty), _get_results (line 491) considered that to be a PEAR error. However, lack of results only means a search came up empty, not that there was an LDAP error. We should check the error code before declaring a problem. The good news is that fixing it, for OpenLDAP anyway, is simple. OpenLDAP returns an error code of 0 when there were no LDAP problems. So it was a simple matter to add a check of the error code before declaring that there was a problem. Tue, 22 Sep 2009 12:46:32 +0000 https://bugs.horde.org/ticket/8595#t55878 Not sure of the correct patch format. So I attached a simple diff to the original ticket. Tue, 22 Sep 2009 12:47:53 +0000 https://bugs.horde.org/ticket/8595#t55879 Changes have been made in CVS for this ticket: Correctly check for ldap_get_entries() result (Bug #8595). http://cvs.horde.org/diff.php/turba/lib/Driver/ldap.php?rt=horde&r1=1.54.4.22&r2=1.54.4.23&ty=u Fri, 25 Sep 2009 13:58:49 +0000 https://bugs.horde.org/ticket/8595#t55940 Fixed Fri, 25 Sep 2009 14:00:30 +0000 https://bugs.horde.org/ticket/8595#t55942 Changes have been made in Git for this ticket: MFB: Don't return an error on empty LDAP search results (Bug #8595). http://git.horde.org/diff.php/turba/docs/CHANGES?rt=horde-hatchery&r1=51147560278fa4243f3d3f1fc193b801c6a3e6a8&r2=9f18210886cb226b13faeaeecd7f02a40091282a http://git.horde.org/diff.php/turba/lib/Driver/Ldap.php?rt=horde-hatchery&r1=05a4fcce01e105c552dae2f1e2fdd363eaa2464b&r2=9f18210886cb226b13faeaeecd7f02a40091282a Fri, 25 Sep 2009 14:04:55 +0000 https://bugs.horde.org/ticket/8595#t55943 Changes have been made in Git for this ticket: MFB: Don't return an error on empty LDAP search results (Bug #8595). http://git.horde.org/diff.php/turba/docs/CHANGES?rt=horde-git&r1=51147560278fa4243f3d3f1fc193b801c6a3e6a8&r2=9f18210886cb226b13faeaeecd7f02a40091282a http://git.horde.org/diff.php/turba/lib/Driver/Ldap.php?rt=horde-git&r1=05a4fcce01e105c552dae2f1e2fdd363eaa2464b&r2=9f18210886cb226b13faeaeecd7f02a40091282a Wed, 13 Jan 2010 00:12:12 +0000 https://bugs.horde.org/ticket/8595#t57627