Sun, 05 Apr 2026 17:18:35 +0000 https://bugs.horde.org/ticket/8482 Session not cleaned up in alarms.php Perhaps I have my sessions mis-configured, but with current alarms.php, I get sessions left around every time my alarms.php cron job runs. The attached patch nukes the session when finished. Wed, 05 Aug 2009 17:12:56 +0000 https://bugs.horde.org/ticket/8482#t55221 That looks like a nice addition. Why do you call clearAuth(), if the session is destroyed anyway? Thu, 06 Aug 2009 10:18:40 +0000 https://bugs.horde.org/ticket/8482#t55239 > That looks like a nice addition. Why do you call clearAuth(), if the > session is destroyed anyway? Only because that's what login.php does for a logout. I just copied what was done there. Wed, 12 Aug 2009 14:27:02 +0000 https://bugs.horde.org/ticket/8482#t55274 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/CLI/Attic/CLI.php?rt=horde&r1=1.42.6.25&r2=1.42.6.26&ty=u Fri, 14 Aug 2009 22:00:29 +0000 https://bugs.horde.org/ticket/8482#t55323 Instead I went ahead and added this as a shutdown method in the CLI constructor, so that the session is destroyed at the end of *any* CLI script. Fri, 14 Aug 2009 22:02:32 +0000 https://bugs.horde.org/ticket/8482#t55324 > Instead I went ahead and added this as a shutdown method in the CLI > constructor, so that the session is destroyed at the end of *any* CLI > script. I tested that, and it seems to work for me. I'm glad you came up with a more comprehensive approach. Thanks for fixing it. Mon, 17 Aug 2009 18:11:31 +0000 https://bugs.horde.org/ticket/8482#t55332 Hmm... as pointed out somewhat by #8701, maybe a better solution would be to avoid opening a session from the CLI in the first place? Thu, 12 Nov 2009 04:02:47 +0000 https://bugs.horde.org/ticket/8482#t56681 The session is not started in CLI, and there's no guarantee that it will be loaded before base.php. Beside that, it wouldn't help with bug 8482, because backend.php wouldn't even work without a session. Thu, 12 Nov 2009 07:50:22 +0000 https://bugs.horde.org/ticket/8482#t56683 > The session is not started in CLI, Maybe for the CLI scripts that do require a session, then the script itself should be responsible for destroying it. At a minimum, we should allow passing an option to CLI to indicate we don't want to kill any active sessions. Thu, 12 Nov 2009 14:55:31 +0000 https://bugs.horde.org/ticket/8482#t56696 What actually requires a functional session when running from the CLI? I was thinking that we should just not call session_start() if php_sapi_name() == 'cli'. Thu, 12 Nov 2009 15:02:21 +0000 https://bugs.horde.org/ticket/8482#t56697 > What actually requires a functional session when running from the > CLI? Doesn't Auth use $_SESSION? So any script that needs an actual user name to be set in auth would require a session, right? Thu, 12 Nov 2009 15:21:31 +0000 https://bugs.horde.org/ticket/8482#t56698 >> What actually requires a functional session when running from the >> CLI? > > Doesn't Auth use $_SESSION? So any script that needs an actual user > name to be set in auth would require a session, right? Yes, and the superglobal is only created when a session is started. Thu, 12 Nov 2009 15:31:25 +0000 https://bugs.horde.org/ticket/8482#t56699 What about only registering the shutdown function if we are running from the cli? i.e.: - register_shutdown_function(array($this, '_shutdown')); + if ($this->_console) { + register_shutdown_function(array($this, '_shutdown')); + } } Fri, 13 Nov 2009 01:51:01 +0000 https://bugs.horde.org/ticket/8482#t56707 That looks reasonable to me... Fri, 13 Nov 2009 05:00:20 +0000 https://bugs.horde.org/ticket/8482#t56709 Good idea. Fri, 13 Nov 2009 08:42:30 +0000 https://bugs.horde.org/ticket/8482#t56711 Changes have been made in CVS for this ticket: Only destroy the session if we are actually running via the cli. Also fixes Bug: 8701 Bug: 8482 http://cvs.horde.org/diff.php/framework/CLI/Attic/CLI.php?rt=horde&r1=1.42.6.27&r2=1.42.6.28&ty=u Fri, 13 Nov 2009 14:28:41 +0000 https://bugs.horde.org/ticket/8482#t56717 Changes have been made in Git for this ticket: Only destroy the session if we are actually running via the cli. Bug: 8482 and also resolves Bug: 8701 http://git.horde.org/diff.php/framework/Cli/lib/Horde/Cli.php?rt=horde-git&r1=4c1ef7437017c2c9aee53eecb0dc3dea03ab3b97&r2=778778570869506ccec9470e15ba9f79c06912d0 Fri, 13 Nov 2009 14:31:35 +0000 https://bugs.horde.org/ticket/8482#t56719