Fri, 10 Apr 2026 19:46:55 +0000 https://bugs.horde.org/ticket/8468 Renaming public folder is wrong Hi, we have a IMAP server (cyrus) with this namespace: NAMESPACE (("INBOX." ".")) (("user." ".")) (("" ".")) We've so-called group mailboxes, aka group.test.folder1 Renaming such a folder within IMP's folder screen moves this folder below user's INBOX, i.e. rename group.test.folder1 to group.test.folder2 leads to INBOX.group.test.folder2, but not to group.test.folder2 IMAP command is Rename group.test.folder1 INBOX.group.test.folder2 Any help is appreciated. Regards, Frank Fri, 31 Jul 2009 14:40:14 +0000 https://bugs.horde.org/ticket/8468#t55099 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/lib/IMP.php?rt=horde&r1=1.449.4.126&r2=1.449.4.127&ty=u Wed, 05 Aug 2009 03:56:39 +0000 https://bugs.horde.org/ticket/8468#t55191 Does this patch fix things? Wed, 05 Aug 2009 03:57:01 +0000 https://bugs.horde.org/ticket/8468#t55193 > Does this patch fix things? It fixes renaming the "group.*" folders, but breaks renaming folders in INBOX. Renaming test to test1 (in INBOX) leads to IMAP command Rename INBOX.test test1 -> Permission denied Thanks, Frank Wed, 05 Aug 2009 06:47:18 +0000 https://bugs.horde.org/ticket/8468#t55196 I knew I had seen this before - this is the same issue as Bug #2874. Wed, 05 Aug 2009 07:03:08 +0000 https://bugs.horde.org/ticket/8468#t55197 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/folders.php?rt=horde&r1=2.309.2.43&r2=2.309.2.44&ty=u Wed, 05 Aug 2009 07:47:06 +0000 https://bugs.horde.org/ticket/8468#t55199 Take 2 - try this latest patch. Essentially, it doesn't try to auto-magically add namespace information. Wed, 05 Aug 2009 07:48:51 +0000 https://bugs.horde.org/ticket/8468#t55200 > Take 2 - try this latest patch. Essentially, it doesn't try to > auto-magically add namespace information. The same behavior as with the previous patch: Renaming group.* (namespace '') folder is ok, renaming in INBOX namespace is wrong. I'd like to rename "test" (in INBOX) to "test1", IMP aks for new name for "test" (not "INBOX.test"), I give "test1" This leads to: Rename INBOX.test test1 -> Permission denied It's a bit tricky for IMP to detect which namespace a folder should go to (if an "empty" namespace '' exists). An approach might be (pseudo code): if ($newfolder starts with "non-empty namespace") { // INBOX.test1 - should be ok to use $newfolder } else { if ($newfolder doesn't contain delimiter - '.' im my server) { // test1 $newfolder = defaultnamespace . $newfolder; } elseif ($newfolder "starts with existing foldername") { // i.e. group.test.test1 -> // group.test exists already -> use $newfolder // if a user wants to create/rename to INBOX.group.test.test1 (a rare case IMHO) // he has to type INBOX.group.test.test1 } elseif () { // other.folder $newfolder defaultnamespace . $newfolder; } } Frank Wed, 05 Aug 2009 10:27:44 +0000 https://bugs.horde.org/ticket/8468#t55208 > An approach might be (pseudo code): > > if ($newfolder starts with "non-empty namespace") { > // INBOX.test1 - should be ok to use $newfolder > } else { > if ($newfolder doesn't contain delimiter - '.' im my server) { > // test1 > $newfolder = defaultnamespace . $newfolder; > } elseif ($newfolder "starts with existing foldername") { > // i.e. group.test.test1 -> > // group.test exists already -> use $newfolder > // if a user wants to create/rename to INBOX.group.test.test1 > (a rare case IMHO) > // he has to type INBOX.group.test.test1 > } elseif () { > // other.folder > $newfolder defaultnamespace . $newfolder; > } > } What if the user wants to rename 'group.test.test1' to 'foo.test2'. It would fall through to your last case and get added as 'INBOX.foo.test2' which is not correct. There are only two ways I can think of to fix: 1. Look at the old mailbox name and only allow a rename within that namespace. 2. Requiring the entire folder name while renaming, but this was what was specifically refused in the previously mentioned ticket since personal namespaces should be invisible to the user. This is why Cyrus' namespace setup has *never* made sense to me. The default namespace should be a user's personal namespace - shared and other folders are special folders that should live under a specific sub-folder. Wed, 05 Aug 2009 21:18:48 +0000 https://bugs.horde.org/ticket/8468#t55229 Re-reading RFC 2342, the assumption seems to be that folders (once created) are restricted to that particular namespace. So we will go with option #1. Wed, 05 Aug 2009 21:29:54 +0000 https://bugs.horde.org/ticket/8468#t55230 >> An approach might be (pseudo code): >> >> if ($newfolder starts with "non-empty namespace") { >> // INBOX.test1 - should be ok to use $newfolder >> } else { >> if ($newfolder doesn't contain delimiter - '.' im my server) { >> // test1 >> $newfolder = defaultnamespace . $newfolder; >> } elseif ($newfolder "starts with existing foldername") { >> // i.e. group.test.test1 -> >> // group.test exists already -> use $newfolder >> // if a user wants to create/rename to INBOX.group.test.test1 >> (a rare case IMHO) >> // he has to type INBOX.group.test.test1 >> } elseif () { >> // other.folder >> $newfolder defaultnamespace . $newfolder; >> } >> } > > What if the user wants to rename 'group.test.test1' to 'foo.test2'. > It would fall through to your last case and get added as > 'INBOX.foo.test2' which is not correct. This is correct IMHO - at least in our environment no user may create toplevel folders in public namespace, so INBOX.foo.test2 is the only solution. > There are only two ways I can think of to fix: > 1. Look at the old mailbox name and only allow a rename within that > namespace. Would be better than now, but not optimal. > 2. Requiring the entire folder name while renaming, but this was what > was specifically refused in the previously mentioned ticket since > personal namespaces should be invisible to the user. That's right, don't do that. > This is why Cyrus' namespace setup has *never* made sense to me. The > default namespace should be a user's personal namespace - shared and > other folders are special folders that should live under a specific > sub-folder. I agree ... In a GUI this moving of folders between namespaces is easier ... Frank Wed, 05 Aug 2009 21:30:33 +0000 https://bugs.horde.org/ticket/8468#t55231 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/folders.php?rt=horde&r1=2.309.2.44&r2=2.309.2.45&ty=u Wed, 05 Aug 2009 21:58:00 +0000 https://bugs.horde.org/ticket/8468#t55232 > http://cvs.horde.org/diff.php/imp/folders.php?rt=horde&r1=2.309.2.44&r2=2.309.2.45&ty=u Try this patch. Wed, 05 Aug 2009 21:59:08 +0000 https://bugs.horde.org/ticket/8468#t55233 >> http://cvs.horde.org/diff.php/imp/folders.php?rt=horde&r1=2.309.2.44&r2=2.309.2.45&ty=u > > Try this patch. I have to change $old_names = array_map('trim', explode("\n", Horde_Util::getFormData('old_names'))); $new_names = array_map('trim', explode("\n", Horde_Util::getFormData('new_names'))); to: $old_names = array_map('trim', explode("\n", Util::getFormData('old_names'))); $new_names = array_map('trim', explode("\n", Util::getFormData('new_names'))); (otherwise it exits - empty page in browser). With this, yes, it works: - renaming folder in INBOX namespace - renaming folder within shared namespace - renaming a shared folder to INBOX: Give INBOX.foldername as new folder name, that's ok. Thank you very much, Frank Thu, 06 Aug 2009 06:33:06 +0000 https://bugs.horde.org/ticket/8468#t55238 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/docs/CHANGES?rt=horde&r1=1.699.2.399&r2=1.699.2.400&ty=u http://cvs.horde.org/diff.php/imp/folders.php?rt=horde&r1=2.309.2.45&r2=2.309.2.46&ty=u Thu, 06 Aug 2009 17:12:45 +0000 https://bugs.horde.org/ticket/8468#t55242 > I have to change > $old_names = array_map('trim', explode("\n", > Horde_Util::getFormData('old_names'))); > $new_names = array_map('trim', explode("\n", > Horde_Util::getFormData('new_names'))); > to: > $old_names = array_map('trim', explode("\n", > Util::getFormData('old_names'))); > $new_names = array_map('trim', explode("\n", > Util::getFormData('new_names'))); Thanks for the catch - my system is set up so that both are available so I didn't notice this. And thanks for helping to resolve this issue. Thu, 06 Aug 2009 17:14:03 +0000 https://bugs.horde.org/ticket/8468#t55243 Changes have been made in Git for this ticket: Bug #8468: When appending namespaces, search for empty namespace. http://git.horde.org/diff.php/imp/lib/Imap.php?rt=horde-git&r1=df8c626194789a61214771c8b5ac07fa870bdc8b&r2=ba5fce1be74c5d90f085e622b806eae53d4acc38 Wed, 13 Jan 2010 00:09:59 +0000 https://bugs.horde.org/ticket/8468#t57591 Changes have been made in Git for this ticket: Bug #8468: Doing too much magic on rename folder name - we have to trust the user at some point. http://git.horde.org/diff.php/imp/folders.php?rt=horde-git&r1=df8c626194789a61214771c8b5ac07fa870bdc8b&r2=8b659fe604f4a3a6af9ea1509029198bdaafa4e3 Wed, 13 Jan 2010 00:10:01 +0000 https://bugs.horde.org/ticket/8468#t57592 Changes have been made in Git for this ticket: Bug #8468: Another stab at renaming fix http://git.horde.org/diff.php/imp/folders.php?rt=horde-git&r1=8b659fe604f4a3a6af9ea1509029198bdaafa4e3&r2=5b9484944bd31302510bc2223a8ba6f1f5b826bd http://git.horde.org/diff.php/imp/lib/IMP.php?rt=horde-git&r1=25e9e426a4d2e25f90ca3685559df73aaaab02f0&r2=5b9484944bd31302510bc2223a8ba6f1f5b826bd Wed, 13 Jan 2010 00:10:05 +0000 https://bugs.horde.org/ticket/8468#t57594 Changes have been made in Git for this ticket: Bug #8468: changelog http://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=e17b03b8b829d220cfd08745c4601c9ad9f8c4a8&r2=890e3714e4e703d757718d0c08c9efaa082c7122 Wed, 13 Jan 2010 00:10:07 +0000 https://bugs.horde.org/ticket/8468#t57595