Thu, 09 Apr 2026 17:31:32 +0000 https://bugs.horde.org/ticket/8323 Use streams for ssh2 driver in VFS I hope I'm posting this in the right queue. It looks like the ssh2_scp_* php functions do not work on some systems. See http://phpbuilder.com/board/showthread.php?t=10352595 and http://forums.devnetwork.net/viewtopic.php?t=80343 for that matter. My system is one of those - everything (!) except uploading and downloading/editing files with Gollem over the SSH2 backend works. However, there is a workaround using the php fopen wrappers. I wrote a quick and dirty hack using this workaround - see the attached diff file for ssh2.php. Thu, 04 Jun 2009 21:21:20 +0000 https://bugs.horde.org/ticket/8323#t54426 Sorry, posted the wrong diff. Here's the right one. Thu, 04 Jun 2009 22:21:19 +0000 https://bugs.horde.org/ticket/8323#t54427 If you are already using streams, why do you read the complete file contents into memory instead of using copy()? You could even replace VFS' copy and move functionality completely by the native PHP calls. Also, please review your patch reading the Horde coding standards (single quotes, lowercase keywords). And if you want the patch to also be applied to the stable branch, you need a fallback if file_put_contents() doesn't exist (PHP 5 only). Fri, 05 Jun 2009 07:19:56 +0000 https://bugs.horde.org/ticket/8323#t54433 > If you are already using streams, why do you read the complete file > contents into memory instead of using copy()? You could even replace > VFS' copy and move functionality completely by the native PHP calls. > Also, please review your patch reading the Horde coding standards > (single quotes, lowercase keywords). And if you want the patch to > also be applied to the stable branch, you need a fallback if > file_put_contents() doesn't exist (PHP 5 only). You are obviously right - there is no need to read the file into memory. As for the replacement of the VFS functions: I don't know if using the native PHP functions is better or worse in terms of compatibility and performance. Because of that and since the ssh2_sftp_*-functions which are used for copying and moving files seem to work on any system (in contrast to the ssh2_scp_*-functions), I didn't touch them. I also tried to adapt my code to comply with the Horde coding standards. Sat, 06 Jun 2009 17:13:50 +0000 https://bugs.horde.org/ticket/8323#t54444 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/ssh2.php?rt=horde&r1=1.12&r2=1.13&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.90&r2=1.91&ty=u Mon, 15 Jun 2009 14:17:32 +0000 https://bugs.horde.org/ticket/8323#t54572 Committed to HEAD and 3.3.5 - thanks! Mon, 15 Jun 2009 14:20:22 +0000 https://bugs.horde.org/ticket/8323#t54573