Summary | Use streams for ssh2 driver in VFS |
Queue | Horde Framework Packages |
Queue Version | HEAD |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | chuck (at) horde (dot) org |
Requester | jives (at) jives (dot) ixum (dot) net |
Created | 2009-06-04 (4246 days ago) |
Due | |
Updated | 2009-06-15 (4235 days ago) |
Assigned | 2009-06-06 (4244 days ago) |
Resolved | 2009-06-15 (4235 days ago) |
Milestone | 3.3.5 |
Patch | Yes |
Assigned to Chuck Hagenbuch
Taken from
State ⇒ Resolved
http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/ssh2.php?rt=horde&r1=1.12&r2=1.13&ty=u
http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.90&r2=1.91&ty=u
State ⇒ Assigned
Milestone ⇒ 3.3.5
Patch ⇒ Yes
New Attachment: ssh2.php.patch
contents into memory instead of using copy()? You could even replace
VFS' copy and move functionality completely by the native PHP calls.
Also, please review your patch reading the Horde coding standards
(single quotes, lowercase keywords). And if you want the patch to
also be applied to the stable branch, you need a fallback if
file_put_contents() doesn't exist (PHP 5 only).
memory. As for the replacement of the VFS functions: I don't know if
using the native PHP functions is better or worse in terms of
compatibility and performance. Because of that and since the
ssh2_sftp_*-functions which are used for copying and moving files seem
to work on any system (in contrast to the ssh2_scp_*-functions), I
didn't touch them.
I also tried to adapt my code to comply with the Horde coding standards.
Summary ⇒ Use streams for ssh2 driver in VFS
State ⇒ Feedback
contents into memory instead of using copy()? You could even replace
VFS' copy and move functionality completely by the native PHP calls.
Also, please review your patch reading the Horde coding standards
(single quotes, lowercase keywords). And if you want the patch to also
be applied to the stable branch, you need a fallback if
file_put_contents() doesn't exist (PHP 5 only).
Version ⇒ HEAD
Queue ⇒ Horde Framework Packages
State ⇒ New
Priority ⇒ 1. Low
New Attachment: ssh2.php[1].diff
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Summary ⇒ Down- and upload over SSH2 partially broken
Queue ⇒ Gollem
Milestone ⇒
Patch ⇒ Yes
New Attachment: ssh2.php.diff
It looks like the ssh2_scp_* php functions do not work on some
systems. See http://phpbuilder.com/board/showthread.php?t=10352595 and
http://forums.devnetwork.net/viewtopic.php?t=80343 for that matter. My
system is one of those - everything (!) except uploading and
downloading/editing files with Gollem over the SSH2 backend works.
However, there is a workaround using the php fopen wrappers. I wrote a
quick and dirty hack using this workaround - see the attached diff
file for ssh2.php.