Wed, 08 Apr 2026 08:01:42 +0000 https://bugs.horde.org/ticket/8175 syncml broken because of tasklist required on update When trying to sync horde tasklist with a recent funambol mozilla client, this failes because it is tried to update a tasklist of an existing task to NULL. In /usr/share/horde/horde/nag/lib/Driver.php on line 345 an error occurs because $share is a PEAR_ERROR. This is not properly caught. The solution is to change line 322 to look like if ($task->tasklist != $tasklist && $tasklist != null) { . This prevents setting a tasklist to NULL. Calling modify with tasklist=NULL looks valid to me, because the parameter is declared optional. Thu, 09 Apr 2009 07:46:10 +0000 https://bugs.horde.org/ticket/8175#t53602 We already *do* test whether $tasklist is null: http://cvs.horde.org/annotate.php/nag/lib/Driver.php?rev=1.57.2.26#l322 Thu, 16 Apr 2009 21:51:14 +0000 https://bugs.horde.org/ticket/8175#t53694 Thanks for no feedback notification, when i read your last message i just thought it would have been included after the release on groupware-webmail-1.2.2 and so no feedback would be required. Looking into the code i found that that line has been included in cvs since 2008 but is not in the stable horde groupware webmail 1.2.2 release end of jan 2009, where code looks like this: % $new_task = $this->get($task->id); % $log_tasklist = $this->_tasklist; 322 % if ($task->tasklist != $tasklist) { % /* Moving the task to another tasklist. */ % $share = $GLOBALS['nag_shares']->getShare($task->tasklist); % if (!is_a($share, 'PEAR_Error') && I don't know why it is not in the released code or how to find the release version in cvs (a GROUPWARE_WEBMAIL_1_2_2 tag would be great). It is probably sufficient to include that line as it is in cvs into the next release. Wed, 29 Apr 2009 18:37:19 +0000 https://bugs.horde.org/ticket/8175#t53937