Fri, 10 Apr 2026 09:50:11 +0000 https://bugs.horde.org/ticket/8103 Filters with no conditions Hi, Now it is possible to create filters without any condition. With maildrop backend, it generates filters like: ##### New Rule ##### if( \ ) exception { to "${DEFAULT}" } And that generates a maildrop error beause of a mailfilter parsing error. I think it makes sense to deny any rule without conditions. I attach a patch to do it. Fri, 20 Mar 2009 11:47:29 +0000 https://bugs.horde.org/ticket/8103#t53195 Hasn't this been fixed with bug #5641 already? Mon, 23 Mar 2009 11:07:01 +0000 https://bugs.horde.org/ticket/8103#t53223 Not exactly. Update made in #5641 ensures that a defined condition is not empty, but doesn't ensures that the rule has at least one condition. Mon, 23 Mar 2009 11:14:49 +0000 https://bugs.horde.org/ticket/8103#t53227 It is perfectly valid having no conditions. The rule should be executed unconditionally then. If this doesn't work in maildrop, then the maildrop driver has to fixed instead. Mon, 23 Mar 2009 11:30:40 +0000 https://bugs.horde.org/ticket/8103#t53229 You are right, an unconditional rule should be valid. Let me try another patch for maildrop driver Mon, 23 Mar 2009 12:31:04 +0000 https://bugs.horde.org/ticket/8103#t53231 This breaks all rules *with* conditions. Mon, 23 Mar 2009 13:36:42 +0000 https://bugs.horde.org/ticket/8103#t53232 I don't think so. The patch checks if any condition exists: if (count($this->_conditions) > 0) { In that case, it add 'if' statments and the conditions. I don't know if i'm missing something, but the patch is working for me. In fact, i think that actual condition looks weird: if (count($this->_conditions > 1)) { Comparing an array with a number before count? Mon, 23 Mar 2009 15:18:05 +0000 https://bugs.horde.org/ticket/8103#t53243 Did you actually test the patch? This is how maildrop scripts look like now: 430: ##### Horde Bugs ##### 431: if( \ 432: /^From:\s*bugs@horde\.org$/:h \ 433: if( \ 434: exception { 435: to INBOX.horde.bugs 436: } Mon, 23 Mar 2009 16:29:14 +0000 https://bugs.horde.org/ticket/8103#t53245 I'm so sorry Jan. I tested the modification in our current version, and later i generated the patch making modifications in CVS HEAD version, but actually i did not test the patch because it was very simple. But i made a stupid mistake. I attach the correct and tested patch. Mon, 23 Mar 2009 21:03:27 +0000 https://bugs.horde.org/ticket/8103#t53250 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/ingo/docs/CHANGES?rt=horde&r1=1.55.2.119&r2=1.55.2.120&ty=u http://cvs.horde.org/diff.php/ingo/lib/Script/maildrop.php?rt=horde&r1=1.7.2.13&r2=1.7.2.14&ty=u Mon, 23 Mar 2009 21:38:23 +0000 https://bugs.horde.org/ticket/8103#t53252 Committed, thanks. If you have a chance, can you take a look at the other open bugs of the maildrop driver? Mon, 23 Mar 2009 21:39:01 +0000 https://bugs.horde.org/ticket/8103#t53253 Changes have been made in Git for this ticket: Fix maildrop rules without conditions (almarin@um.es, Bug #8103). http://git.horde.org/diff.php/ingo/docs/CHANGES?rt=horde-git&r1=82c209c8e71b9473af38085588bda376ab370f98&r2=14e76278f3f4a3f9ce9ff2c56f12c899c74386a4 http://git.horde.org/diff.php/ingo/lib/Script/maildrop.php?rt=horde-git&r1=82c209c8e71b9473af38085588bda376ab370f98&r2=14e76278f3f4a3f9ce9ff2c56f12c899c74386a4 Wed, 13 Jan 2010 00:00:54 +0000 https://bugs.horde.org/ticket/8103#t57538