Fri, 10 Apr 2026 01:05:01 +0000 https://bugs.horde.org/ticket/8079 Avoid notice in _removeBr from Text_Filter/Filter/highlightquotes.php In some circumstances $lines does only contain <br /> and thus a notice is thrown from the second loop. Fri, 13 Mar 2009 15:13:43 +0000 https://bugs.horde.org/ticket/8079#t53068 HMPF, typo in my patch. Added fixed one. Fri, 13 Mar 2009 15:15:10 +0000 https://bugs.horde.org/ticket/8079#t53069 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Text_Filter/Filter/highlightquotes.php?rt=horde&r1=1.41&r2=1.42&ty=u Fri, 13 Mar 2009 18:46:41 +0000 https://bugs.horde.org/ticket/8079#t53079 How about my patch, which removes for() loops entirely? Fri, 13 Mar 2009 18:47:19 +0000 https://bugs.horde.org/ticket/8079#t53080 > How about my patch, which removes for() loops entirely? Looks also fine to me. Instead of: foreach (array_keys($lines) as $i) { You could use: foreach ($lines as $i => $line) { if (!preg_match("/^\s*<br\s*\/>\s*$/i", $line)) { ... To eliminate the extra array_keys() call. But at the end its the same. Your new approach is _technically seen_ maybe a little more expensive, but it does indeed remove the "unnice" for() loop. I am fine either. - Jens Fri, 13 Mar 2009 19:04:34 +0000 https://bugs.horde.org/ticket/8079#t53082 > Instead of: > foreach (array_keys($lines) as $i) { > You could use: > foreach ($lines as $i => $line) { > if (!preg_match("/^\s*<br\s*\/>\s*$/i", $line)) { > ... > > To eliminate the extra array_keys() call. No, you can't do that. Since foreach() works on a copy of the original array, the unset() calls would not destroy the data contained in the initial array. Thus the need to iterate through the array keys and use them to access the original variable. Fri, 13 Mar 2009 19:11:34 +0000 https://bugs.horde.org/ticket/8079#t53084