Thu, 09 Apr 2026 22:17:57 +0000 https://bugs.horde.org/ticket/8041 User-facing notifications shouldn't contain stack traces or talk about exceptions Example: exception 'Horde_Exception' with message 'This request cannot be completed because the link you followed or the form you submitted was only valid for 30 minutes. Please try again now.' in /var/www/horde/horde-hatchery/imp/lib/IMP.php:138 Stack trace: #0 /var/www/horde/horde-hatchery/imp/compose.php(117): IMP::checkRequestToken('imp.compose', 'VTpiA2aW_Z5yeLN...') #1 {main} Mon, 02 Mar 2009 22:08:17 +0000 https://bugs.horde.org/ticket/8041#t52836 This is probably better described as removing all of the following from IMP: $notification->push($e) where $e is an Exception, and replacing with: $notification->push($e->getMessage() [, $e->getCode]); Mon, 02 Mar 2009 22:28:30 +0000 https://bugs.horde.org/ticket/8041#t52842 I don't agree. Pushing exceptions should be as easy as pushing PEAR_Errors. If necessary we should refactor Notification instead. Mon, 02 Mar 2009 23:11:38 +0000 https://bugs.horde.org/ticket/8041#t52845 > I don't agree. Pushing exceptions should be as easy as pushing > PEAR_Errors. If necessary we should refactor Notification instead. I guess I am confused, since I thought you were arguing for exactly the opposite here: http://lists.horde.org/archives/dev/Week-of-Mon-20090223/023797.html I *want* to be able to push Exceptions onto the Notification stack, but I thought that I had been outvoted re: this issue. Mon, 02 Mar 2009 23:33:28 +0000 https://bugs.horde.org/ticket/8041#t52858 As far as I understood the outcome was just to not use error/exception codes for notification classes. My "if you really want" was rather pointing at the fact that we didn't talk about how to deal with exceptions in the frontend in H4 at all. Pushing them as notifications might still be the best solution, but since we re-think everything, someone might come up with a better idea. And to voice my opinion: I still like notifications, though we might also need a general handler for uncatched exceptions. Heck, I wrote that stuff 7 years ago. :-) Mon, 02 Mar 2009 23:55:53 +0000 https://bugs.horde.org/ticket/8041#t52859 Resolving for now, since I believe my initial commits have been backed out over the last few months. Tue, 19 May 2009 15:02:50 +0000 https://bugs.horde.org/ticket/8041#t54253 Nope - I still get exception message from git IMP (when I take too long to use a link, for example). Fri, 22 May 2009 20:27:31 +0000 https://bugs.horde.org/ticket/8041#t54289 > Nope - I still get exception message from git IMP (when I take too > long to use a link, for example). Did somebody revert all the changes I made where I was passing the Exception object directly to the notification stack? I haven't touched any of them. It's probably easiest to simply pick them off one-by-one as they are encountered instead. Fri, 29 May 2009 05:45:51 +0000 https://bugs.horde.org/ticket/8041#t54339 Going to close this. We can deal with these errors when they show up. Tue, 30 Jun 2009 18:47:02 +0000 https://bugs.horde.org/ticket/8041#t54754