Fri, 10 Apr 2026 05:21:32 +0000 https://bugs.horde.org/ticket/7934 smb driver's _command needs to be charset aware smb driver's _command() function needs to sey LC_CTYPE enviroment variable. Otherwise gollem is not able show correctly or search for file names with accented characters. Mon, 02 Feb 2009 15:23:28 +0000 https://bugs.horde.org/ticket/7934#t52206 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.3&r2=1.4&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.88&r2=1.89&ty=u Fri, 06 Feb 2009 17:56:52 +0000 https://bugs.horde.org/ticket/7934#t52343 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.1.2.3&r2=1.1.2.4&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.36.4.27&r2=1.36.4.28&ty=u Fri, 06 Feb 2009 17:57:48 +0000 https://bugs.horde.org/ticket/7934#t52344 Added. Fri, 06 Feb 2009 17:58:08 +0000 https://bugs.horde.org/ticket/7934#t52345 That doesn't make any sense to me because - we already set LC_ALL in horde - this only works with horde anyway, but this is a pear package. please revert. Fri, 06 Feb 2009 18:00:17 +0000 https://bugs.horde.org/ticket/7934#t52346 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.4&r2=1.5&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.89&r2=1.90&ty=u Fri, 06 Feb 2009 18:23:02 +0000 https://bugs.horde.org/ticket/7934#t52350 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/smb.php?rt=horde&r1=1.1.2.4&r2=1.1.2.5&ty=u http://cvs.horde.org/diff.php/framework/VFS/package.xml?rt=horde&r1=1.36.4.28&r2=1.36.4.29&ty=u Fri, 06 Feb 2009 18:24:28 +0000 https://bugs.horde.org/ticket/7934#t52351 > That doesn't make any sense to me because > - we already set LC_ALL in horde > - this only works with horde anyway, but this is a pear package. > please revert. Done. Although the 1st point seems irrelevant to me: if this is truly a PEAR package, then we necessarily have to set LC_* inside the driver because there are no guarantees that it will have been set elsewhere since Horde is not a pre-requisite. Fri, 06 Feb 2009 18:26:06 +0000 https://bugs.horde.org/ticket/7934#t52352 >> That doesn't make any sense to me because >> - we already set LC_ALL in horde That may be, but that environment is not passed to smbclient command in _command(). >> - this only works with horde anyway, but this is a pear package. >> please revert. > > Done. Although the 1st point seems irrelevant to me: if this is > truly a PEAR package, then we necessarily have to set LC_* inside the > driver because there are no guarantees that it will have been set > elsewhere since Horde is not a pre-requisite. My testing showed that smbdriver might work correctly without this patch, but only if host's default environment and the current locale in gollem use the same charset. Fri, 06 Feb 2009 19:58:30 +0000 https://bugs.horde.org/ticket/7934#t52360 >> That doesn't make any sense to me because >> - we already set LC_ALL in horde >> - this only works with horde anyway, but this is a pear package. >> please revert. > > Done. Although the 1st point seems irrelevant to me: if this is > truly a PEAR package, then we necessarily have to set LC_* inside the > driver because there are no guarantees that it will have been set > elsewhere since Horde is not a pre-requisite. But we don't know which locale to use, if not using Horde. Fri, 06 Feb 2009 23:11:43 +0000 https://bugs.horde.org/ticket/7934#t52363 >>> That doesn't make any sense to me because >>> - we already set LC_ALL in horde > > That may be, but that environment is not passed to smbclient command > in _command(). This might be a problem with your system, if LC_ALL doesn't set LC_CTYPE. Or are you saying that LC_ALL isn't set either? >>> - this only works with horde anyway, but this is a pear package. >>> please revert. >> >> Done. Although the 1st point seems irrelevant to me: if this is >> truly a PEAR package, then we necessarily have to set LC_* inside the >> driver because there are no guarantees that it will have been set >> elsewhere since Horde is not a pre-requisite. > > My testing showed that smbdriver might work correctly without this > patch, but only if host's default environment and the current locale > in gollem use the same charset. But the assumption that the files in the Samba backend have the same locale like the current Horde frontend is completely wrong. If at all, then we need to specify a charset per backend, and convert to/from that. Fri, 06 Feb 2009 23:16:08 +0000 https://bugs.horde.org/ticket/7934#t52364 >>>> That doesn't make any sense to me because >>>> - we already set LC_ALL in horde >> >> That may be, but that environment is not passed to smbclient command >> in _command(). > > This might be a problem with your system, if LC_ALL doesn't set > LC_CTYPE. Or are you saying that LC_ALL isn't set either? > From my point of view in the testing, it seems that the LC_ALL is not set when the smbclient command is evoked in the smb backend driver. >>>> - this only works with horde anyway, but this is a pear package. >>>> please revert. >>> >>> Done. Although the 1st point seems irrelevant to me: if this is >>> truly a PEAR package, then we necessarily have to set LC_* inside the >>> driver because there are no guarantees that it will have been set >>> elsewhere since Horde is not a pre-requisite. >> >> My testing showed that smbdriver might work correctly without this >> patch, but only if host's default environment and the current locale >> in gollem use the same charset. > > But the assumption that the files in the Samba backend have the same > locale like the current Horde frontend is completely wrong. If at > all, then we need to specify a charset per backend, and convert > to/from that. Actually smbclient command does the character conversion for you when you give the character set you want in the LC_CTYPE. Fri, 06 Feb 2009 23:41:14 +0000 https://bugs.horde.org/ticket/7934#t52371 Possible duplicate (or at least similar) to Ticket #5725? Tue, 10 Feb 2009 18:08:07 +0000 https://bugs.horde.org/ticket/7934#t52469 Agreed. Tue, 10 Feb 2009 19:28:33 +0000 https://bugs.horde.org/ticket/7934#t52476 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/NLS/NLS.php?rt=horde&r1=1.82.4.23&r2=1.82.4.24&ty=u Sun, 31 May 2009 17:13:52 +0000 https://bugs.horde.org/ticket/7934#t54370