Thu, 09 Apr 2026 21:57:59 +0000 https://bugs.horde.org/ticket/7380 strip style attributes code and Firefox 3.0.1 (Mozilla 5) I have a HTML email message that is not rendered correctly in IMP (it mixes with the IMP code). I think that the correct behavior is to strip the style tags, but this didn't happens in Firefox 3.0.1. There is a test in lib/Horde/MIME/Viewer/html.php that checks for the major version of Mozilla. This triggers the strip style attributes code / regexp in xss.php. But It is checking only against version 4; Firefox 3.0.1 major version is 5, so the strip style code doesn't runs. Tue, 23 Sep 2008 20:53:43 +0000 https://bugs.horde.org/ticket/7380#t49175 This has nothing to do with each other. It's always possible that an HTML message is breaking the page layout, you have to live with that if you enable inline rendering of HTML messages. That being said, we *do* filter out style tags for any browser when rendering those messages inline. It's a bug if that doesn't happen. Please upload an example message. Tue, 23 Sep 2008 21:18:18 +0000 https://bugs.horde.org/ticket/7380#t49176 > This has nothing to do with each other. It's always possible that an > HTML message is breaking the page layout, you have to live with that > if you enable inline rendering of HTML messages. Yes, I know. > That being said, we *do* filter out style tags for any browser when > rendering those messages inline. It's a bug if that doesn't happen. But the style tags are not being filtered out, because of the Mozilla version. The code from html.php is: $strip_style_attributes = (($browser->isBrowser('mozilla') && $browser->getMajor() == 4) || $browser->isBrowser('msie')); So when $browser->getMajor() == 5, $strip_style_attributes = 0 If I change the code to accept the 5 version, then strip_style_attributes = 1 and the page is rendered ok. > Please upload an example message. Uploaded as an attachment. Tue, 23 Sep 2008 21:45:59 +0000 https://bugs.horde.org/ticket/7380#t49177 >> That being said, we *do* filter out style tags for any browser when >> rendering those messages inline. It's a bug if that doesn't happen. > > But the style tags are not being filtered out, because of the Mozilla > version. style tags != style attributes Wed, 24 Sep 2008 16:54:31 +0000 https://bugs.horde.org/ticket/7380#t49194 >>> That being said, we *do* filter out style tags for any browser when >>> rendering those messages inline. It's a bug if that doesn't happen. >> >> But the style tags are not being filtered out, because of the Mozilla >> version. > > style tags != style attributes Sorry, what I mean are the style attributes . Those are that are not being filtered out as they should. Wed, 24 Sep 2008 17:16:40 +0000 https://bugs.horde.org/ticket/7380#t49196 Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/imp/lib/MIME/Viewer/html.php?r1=1.148&r2=1.149&ty=u Wed, 24 Sep 2008 17:16:50 +0000 https://bugs.horde.org/ticket/7380#t49197 We filter out "position: absolute" styles now. Wed, 24 Sep 2008 17:17:22 +0000 https://bugs.horde.org/ticket/7380#t49198